asim: pass false to ReplicaChangeDelayFn for AllocationTransferLeaseOp

Previously, we incorrectly passed true to ReplicaChangeDelayFn for
AllocationTransferLeaseOp, causing it to treat the operation like a replica
addition and extend the delay based on range size and snapshot rate. Since lease
transfers are expected to be much faster, this was unintended. This commit fixes
the issue by applying only the base delay (ReplicaChangeBaseDelay) to
AllocationTransferLeaseOp, which defaults to 100ms.

Epic: none
Release note: none

Author: wenyihu6

pkg/kv/kvserver/asim/queue/replicate_queue.go

@@ -179,7 +179,7 @@ func pushReplicateChange(
 			RangeID:        state.RangeID(change.Replica.GetRangeID()),
 			TransferTarget: state.StoreID(op.Target.StoreID),
 			Author:         state.StoreID(op.Source.StoreID),
-			Wait:           delayFn(rng.Size(), true),
+			Wait:           delayFn(rng.Size(), false /* add */),
 		}
 	case plan.AllocationChangeReplicasOp:
 		log.VEventf(ctx, 1, "pushing state change for range=%s, details=%s", rng, op.Details)

pkg/kv/kvserver/asim/tests/testdata/non_rand/example_fulldisk.txt

@@ -23,46 +23,46 @@ OK
 # store 5. This is shown below as it sheds replicas.
 plot stat=replicas
 ----
- 346 ┤                                    ╭╮╭╮    ╭╮╮╭╮   ╭╮╭╭─╮  ╭╮╮─╭─╮─╭╮─╭────╮─╭
- 333 ┤     ╭╮ ╭╮    ╭╮╭╭╮╭╮─╭─╮╭╭──╮╮╭────╮╭─╮╭╮╭──────╮╭─╯╰─╯╮╰──╯╰──╯─╰─╯╰─╯│╰─╯╰─╯
- 320 ┤ ╭───╭──╮╭───────╮╭╯╰─╯╰╰─╯╰─╰─╯╯╰─╯││╯╰╯╰╯╯╯╰─╯ ╰╯ ╰─╯ ╰╯   ╰╯  ╰╯     ╰─╯ ╰─╯
- 307 ┼╮────╯╯╯╰╯╯ ╰╯╰╯╯╰╯╯ ╰╯╰╯           ╰╯
- 293 ┤╰╮
- 280 ┤ │
- 267 ┤ ╰╮╭╮ ╭╮
- 254 ┤  ╰╯╰─╯│╭─╮ ╭╮
+ 347 ┤                                       ╭╮            ╭╮╭╭╮ ╭╮╭──╭╮─╭╮─╭╮─╭──╮╮╭
+ 334 ┤     ╭╮ ╭╮    ╭╮  ╭─╮╮╭╮──╭╮╮╭╮─╭───╮─╭───────╮╭──╮╭─╯╰╮╭──╯╰╮╭─╯╰─╯╰─╯╰─╯─╯│╰╭
+ 321 ┤ ╭───╭──╮╭╭───────╯╭│╭────╯╰─╯╰─╯╮╭─╰─╯╰╯╮╭╰─╯╰╯─╯╰╯╯╰─╰╯╰╮╭╯╰╯  ╰╯╰─╯      ╰─╯
+ 307 ┼╮────╯╯╯╰─╯╰╯╯╰╯╯ ╰╯╰╯╯ ╰╯ ╰╯    ╰╯      ╰╯               ╰╯
+ 294 ┤╰╮
+ 281 ┤ │
+ 268 ┤ ╰╮╭╮ ╭╮
+ 255 ┤  ╰╯╰─╯│╭─╮ ╭╮
  241 ┤       ╰╯ ╰─╯│╭─╮╭─╮ ╭╮
- 228 ┤             ╰╯ ╰╯ │╭╯│╭─╮ ╭╮ ╭╮
- 214 ┤                   ╰╯ ╰╯ ╰─╯╰╮│╰╮╭╮ ╭╮ ╭╮ ╭╮
- 201 ┤                             ╰╯ ││╰─╯╰╮││ │╰╮ ╭╮ ╭╮     ╭─╮
- 188 ┤                                ╰╯    ╰╯╰─╯ ╰─╯│╭╯╰╮╭─╮ │ │   ╭╮ ╭╮
- 175 ┤                                               ╰╯  ╰╯ ╰─╯ ╰─╮╭╯╰╮│╰╮ ╭╮  ╭╮ ╭╮
- 162 ┤                                                            ╰╯  ╰╯ ╰─╯╰──╯╰╮│╰─
- 149 ┤                                                                           ╰╯
+ 228 ┤             ╰╯ ╰╯ │╭╯╰╮╭╮ ╭╮ ╭╮
+ 215 ┤                   ╰╯  ╰╯╰─╯╰─╯╰╮╭─╮    ╭╮
+ 202 ┤                                ╰╯ │╭─╮ │╰╮╭╮ ╭─╮ ╭╮     ╭╮
+ 189 ┤                                   ╰╯ ╰─╯ ╰╯╰╮│ │ │╰╮╭─╮ │╰╮ ╭╮  ╭╮
+ 175 ┤                                             ╰╯ ╰─╯ ╰╯ ╰─╯ ╰─╯╰╮ │╰╮╭─╮ ╭─╮ ╭─╮
+ 162 ┤                                                               ╰─╯ ╰╯ │ │ │ │ ╰
+ 149 ┤                                                                      ╰─╯ ╰─╯
                                           replicas
 initial store values: [s1=300, s2=300, s3=300, s4=300, s5=300] (stddev=0.00, mean=300.00, sum=1500)
-last store values: [s1=346, s2=326, s3=342, s4=339, s5=153] (stddev=74.40, mean=301.20, sum=1506)
+last store values: [s1=347, s2=342, s3=338, s4=336, s5=152] (stddev=75.59, mean=303.00, sum=1515)
 
 # Plot the % of disk storage capacity used. We should see s5 hovering right
 # around 92.5-95% (the storage capacity threshold value).
 plot stat=disk_fraction_used
 ----
- 1.06 ┤                                                        ╭╮                  ╭╮
- 1.00 ┼─╮                                     ╭╮ ╭╮  ╭╮ ╭╮  ╭╮ │╰╮   ╭╮ ╭╮  ╭╮  ╭╮ │╰╮
- 0.95 ┤ │ ╭╮ ╭╮ ╭╮ ╭╮╭─╮╭─╮ ╭╮╭─╮╭─╮ ╭─╮╭─╮╭─╮││ │╰╮ ││ │╰╮╭╯│ │ ╰─╮╭╯╰╮│╰╮╭╯╰╮╭╯│ │ │
- 0.89 ┤ ╰─╯╰─╯╰─╯╰─╯╰╯ ╰╯ ╰─╯╰╯ ╰╯ ╰─╯ ││ ╰╯ ╰╯╰─╯ ╰─╯╰─╯ ╰╯ ╰─╯   ││  ╰╯ ╰╯  ╰╯ ╰─╯ ╰
- 0.83 ┤                                ╰╯                          ╰╯
+ 1.05 ┼╮                                                        ╭╮  ╭╮  ╭╮
+ 0.99 ┤╰╮                   ╭╮ ╭╮ ╭╮ ╭╮ ╭╮     ╭╮ ╭╮ ╭─╮ ╭╮  ╭╮ │╰╮ ││  ││ ╭╮  ╭─╮ ╭─╮
+ 0.94 ┤ ╰╮╭╮ ╭╮╭─╮╭─╮╭─╮╭─╮╭╯╰╮│╰╮│╰─╯╰╮│╰╮╭─╮ │╰╮││ │ │ │╰╮╭╯╰╮│ ╰─╯╰╮╭╯╰╮│╰╮ │ │ │ │
+ 0.88 ┤  ╰╯╰─╯╰╯ ╰╯ ╰╯ ╰╯ ╰╯  ╰╯ ╰╯    ╰╯ ╰╯ │╭╯ ╰╯╰─╯ ╰─╯ ╰╯  ╰╯     ╰╯  ╰╯ ╰─╯ ╰─╯ ╰
+ 0.82 ┤                                      ╰╯
  0.77 ┤
- 0.72 ┤
- 0.66 ┤
+ 0.71 ┤
+ 0.65 ┤
  0.60 ┤
- 0.55 ┤
+ 0.54 ┤
  0.49 ┤
  0.43 ┤
- 0.38 ┤                                                            ╭╮╮╭╭─╮╭───────────
- 0.32 ┤                                    ╭╮╭╮╭╮─╭────────────────────╯╯╰╯    ╰╯
- 0.26 ┤                 ╭╭─╮╭──────────────────╯╰─╯╯
- 0.20 ┼──────────────────╯╯╰╯╯
+ 0.37 ┤                                                           ╭╮╭─╭───────────────
+ 0.32 ┤                                    ╭──╭───────────────────╯╰──╯╰─╯
+ 0.26 ┤              ╭╮╭╮╭─╮╭─────────────────╯╯─╯
+ 0.20 ┼────────────────╯╰╯╯╰╯╯
                                       disk_fraction_used
 initial store values: [s1=0.20, s2=0.20, s3=0.20, s4=0.20, s5=1.05] (stddev=0.34, mean=0.37, sum=2)
-last store values: [s1=0.42, s2=0.39, s3=0.41, s4=0.41, s5=0.93] (stddev=0.21, mean=0.51, sum=3)
+last store values: [s1=0.41, s2=0.41, s3=0.40, s4=0.40, s5=0.93] (stddev=0.21, mean=0.51, sum=3)