clusterversion: bump PreviousVersion

Bump PreviousVersion to 25.3, add
cockroach-go-testserver-25.3 tests.

This is part of the [M.3 checklist](https://github.com/cockroachdb/cockroach/blob/master/pkg/clusterversion/README.md#m3-enable-upgrade-tests)
(the roachtest fixtures were already done in #150712).

- [x] Update `PreviousRelease` constant to 25.3.

- [x] Verify the logic in `supportsSkipUpgradeTo`
  (`pkg/cmd/roachtest/roachtestutil/mixedversion/mixedversion.go`) is correct
  for the new release.

- [x] Add `cockroach-go-testserver-25.3` logictest config and add it to
  `cockroach-go-testserver-configs`. Update the visibility for
  `cockroach_predecessor_version` in `pkg/sql/logictest/BUILD.bazel`. Run
  `./dev gen` and fix up any tests that fail (using a draft PR helps).

- [x] Check that all gates for the previous release are identical on the
  `master` and release branch.

Epic: REL-2736
Release note: None

Author: nameisbhaskar

pkg/BUILD.bazel

@@ -508,6 +508,7 @@ ALL_TESTS = [
     "//pkg/sql/logictest/tests/5node-disk:5node-disk_test",
     "//pkg/sql/logictest/tests/5node:5node_test",
     "//pkg/sql/logictest/tests/cockroach-go-testserver-25.2:cockroach-go-testserver-25_2_test",
+    "//pkg/sql/logictest/tests/cockroach-go-testserver-25.3:cockroach-go-testserver-25_3_test",
     "//pkg/sql/logictest/tests/fakedist-disk:fakedist-disk_test",
     "//pkg/sql/logictest/tests/fakedist-vec-off:fakedist-vec-off_test",
     "//pkg/sql/logictest/tests/fakedist:fakedist_test",
@@ -2053,6 +2054,7 @@ GO_TARGETS = [
     "//pkg/sql/logictest/tests/5node-disk:5node-disk_test",
     "//pkg/sql/logictest/tests/5node:5node_test",
     "//pkg/sql/logictest/tests/cockroach-go-testserver-25.2:cockroach-go-testserver-25_2_test",
+    "//pkg/sql/logictest/tests/cockroach-go-testserver-25.3:cockroach-go-testserver-25_3_test",
     "//pkg/sql/logictest/tests/fakedist-disk:fakedist-disk_test",
     "//pkg/sql/logictest/tests/fakedist-vec-off:fakedist-vec-off_test",
     "//pkg/sql/logictest/tests/fakedist:fakedist_test",

pkg/cli/testdata/declarative-rules/deprules

@@ -1,6 +1,6 @@
 dep
 ----
-debug declarative-print-rules 1000025.2 dep
+debug declarative-print-rules 1000025.3 dep
 deprules
 ----
 - name: 'CheckConstraint transitions to ABSENT uphold 2-version invariant: PUBLIC->VALIDATED'

pkg/clusterversion/cockroach_versions.go

@@ -283,7 +283,7 @@ const MinSupported Key = V25_2
 
 // PreviousRelease is the logical cluster version of the previous release (which must
 // have at least an RC build published).
-const PreviousRelease Key = V25_2
+const PreviousRelease Key = V25_3
 
 // V25_4 is a placeholder that will eventually be replaced by the actual 25.4
 // version Key, but in the meantime it points to the latest Key. The placeholder

pkg/crosscluster/logical/logical_replication_job_test.go

@@ -2889,7 +2889,7 @@ func TestGetWriterType(t *testing.T) {
 
 	t.Run("immediate-mode", func(t *testing.T) {
 		st := cluster.MakeTestingClusterSettingsWithVersions(
-			clusterversion.V25_2.Version(),
+			clusterversion.V25_3.Version(),
 			clusterversion.PreviousRelease.Version(),
 			true, /* initializeVersion */
 		)

pkg/sql/logictest/BUILD.bazel

@@ -39,8 +39,10 @@ filegroup(
     visibility = [
         "//pkg/ccl/logictestccl/tests/cockroach-go-testserver-25.1:__pkg__",
         "//pkg/ccl/logictestccl/tests/cockroach-go-testserver-25.2:__pkg__",
+        "//pkg/ccl/logictestccl/tests/cockroach-go-testserver-25.3:__pkg__",
         "//pkg/sql/logictest/tests/cockroach-go-testserver-25.1:__pkg__",
         "//pkg/sql/logictest/tests/cockroach-go-testserver-25.2:__pkg__",
+        "//pkg/sql/logictest/tests/cockroach-go-testserver-25.3:__pkg__",
     ],
 )
 

pkg/sql/logictest/logictestbase/logictestbase.go

@@ -520,6 +520,14 @@ var LogicTestConfigs = []TestClusterConfig{
 		BootstrapVersion:         clusterversion.V25_2,
 		NumNodes:                 3,
 	},
+	{
+		// This config runs a cluster with 3 nodes, with a separate process per
+		// node. The nodes initially start on v25.3.
+		Name:                     "cockroach-go-testserver-25.3",
+		UseCockroachGoTestserver: true,
+		BootstrapVersion:         clusterversion.V25_3,
+		NumNodes:                 3,
+	},
 }
 
 // ConfigIdx is an index in the above slice.
@@ -640,6 +648,7 @@ var DefaultConfigSets = map[string]ConfigSet{
 	// Special alias for all testserver configs (for mixed-version testing).
 	"cockroach-go-testserver-configs": makeConfigSet(
 		"cockroach-go-testserver-25.2",
+		"cockroach-go-testserver-25.3",
 	),
 
 	// Special alias for configs where schema locked is disabled.

pkg/sql/logictest/testdata/logic_test/vector_index_mixed

@@ -1,4 +1,4 @@
-# LogicTest: cockroach-go-testserver-configs
+# LogicTest: cockroach-go-testserver-25.2
 
 # Test version gating of op classes in vector index
 

pkg/sql/logictest/tests/cockroach-go-testserver-25.3/BUILD.bazel

@@ -0,0 +1,29 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_test")
+
+go_test(
+    name = "cockroach-go-testserver-25_3_test",
+    size = "enormous",
+    srcs = ["generated_test.go"],
+    data = [
+        "//c-deps:libgeos",  # keep
+        "//pkg/cmd/cockroach-short",  # keep
+        "//pkg/sql/logictest:cockroach_predecessor_version",  # keep
+        "//pkg/sql/logictest:testdata",  # keep
+    ],
+    exec_properties = {"test.Pool": "heavy"},
+    shard_count = 7,
+    tags = ["cpu:3"],
+    deps = [
+        "//pkg/base",
+        "//pkg/build/bazel",
+        "//pkg/security/securityassets",
+        "//pkg/security/securitytest",
+        "//pkg/server",
+        "//pkg/sql/logictest",
+        "//pkg/testutils/serverutils",
+        "//pkg/testutils/skip",
+        "//pkg/testutils/testcluster",
+        "//pkg/util/leaktest",
+        "//pkg/util/randutil",
+    ],
+)