asim: add time.Second to snapshot rate delay calculation

Previously, the delay calculation used snapshot_rate (per second) but forgot to
multiply the result by time.Second, resulting in an incorrectly small delay in
nanoseconds. This commit fixes the bug by applying the correct time unit.

Epic: none
Release note: none

Author: wenyihu6

pkg/kv/kvserver/asim/config/settings.go

@@ -152,7 +152,7 @@ func (s *SimulationSettings) ReplicaChangeDelayFn() func(rangeSize int64, add bo
 	return func(rangeSize int64, add bool) time.Duration {
 		delay := s.ReplicaChangeBaseDelay
 		if add {
-			delay += (time.Duration(rangeSize) / time.Duration(s.RebalancingSnapshotRate))
+			delay += (time.Duration(rangeSize) / time.Duration(s.RebalancingSnapshotRate)) * time.Second
 		}
 		return delay
 	}

pkg/kv/kvserver/asim/tests/testdata/non_rand/example_add_node

@@ -35,24 +35,24 @@ OK
 # 300 replicas as well.
 plot stat=replicas sample=1
 ----
- 301 ┼─────────────────────────────────────╭─╭───────────────────────────────────────
- 281 ┤                                   ╭───╯
- 261 ┤                                ╭╭─╯
+ 301 ┼──────────────────────────────────────╭────────────────────────────────────────
+ 281 ┤                                   ╭──╯
+ 261 ┤                                 ╭─╯╯
  241 ┤                              ╭──╯
- 221 ┤                           ╭──╯
- 201 ┤                        ╭──╯
- 181 ┤                      ╭─╯╯
- 161 ┤                   ╭──╯
- 140 ┤                ╭──╯╯
- 120 ┤              ╭─╯╯
- 100 ┤           ╭──╯
-  80 ┤        ╭──╯╯
-  60 ┤      ╭─╯╯
-  40 ┤    ╭─╯
+ 221 ┤                           ╭╭─╯╯
+ 201 ┤                         ╭──╯
+ 181 ┤                      ╭──╯
+ 161 ┤                    ╭─╯╯
+ 140 ┤                 ╭╭─╯
+ 120 ┤              ╭╭──╯
+ 100 ┤            ╭──╯
+  80 ┤         ╭──╯
+  60 ┤      ╭╭─╯
+  40 ┤    ╭──╯
   20 ┤ ╭──╯
    0 ┼─╯
                                           replicas
 initial store values: [s1=301, s2=0, s3=0] (stddev=141.89, mean=100.33, sum=301)
-last store values: [s1=300, s2=301, s3=300] (stddev=0.47, mean=300.33, sum=901)
+last store values: [s1=300, s2=300, s3=301] (stddev=0.47, mean=300.33, sum=901)
 
 # vim:ft=sh

pkg/kv/kvserver/asim/tests/testdata/non_rand/example_fulldisk

@@ -19,46 +19,46 @@ OK
 # store 5. This is shown below as it sheds replicas.
 plot stat=replicas
 ----
- 342 ┤                                                            ╭╮  ╭╮  ╭╮ ╭╮╭─╭─╮╭
- 329 ┤                             ╭╮╭╭╮╭╮─╭╮╭──╮╭╭──────────────────────────╯╰──╯╯╰─
- 317 ┤                       ╭╮╭──╮─╭─╯╰╯╰─╯╰╯──╰─╯╰╯╰╯
- 304 ┼╮──────────────────────╯╰╯╰╯╰─╯
- 291 ┤╰───────────────────╮ ╰╯
- 278 ┤                    ╰──╮
- 266 ┤                       ╰╮
- 253 ┤                        ╰╮
- 240 ┤                         ╰──╮
- 227 ┤                            ╰─╮
- 215 ┤                              ╰────╮
- 202 ┤                                   ╰───╮╭───╮
- 189 ┤                                       ╰╯   ╰────╮
- 176 ┤                                                 ╰───────╮ ╭─╮
- 164 ┤                                                         ╰─╯ ╰──╮╭─────╮╭╮
- 151 ┤                                                                ╰╯     ╰╯╰─────
+ 345 ┤                                                    ╭╮               ╭╮
+ 334 ┤                      ╭─╮ ╭╮         ╭╮╭─╮╭╮╭╮╭╮╭─╭╮╯│     ╭─╭╮╭╮  ╭╮╯│╭─╭─╮╮─╭
+ 324 ┤             ╭╮╭─╮ ╭╭─│─│╭╯╭─╮╭─╭──╮╭╮╭─╮│╯╭╯╰╮╰╮╭╯│╮╰╮╭─╮╭╯╭╯╰╮─╮╭╯╰╮─╯╭│╯╰╮╮╭
+ 313 ┤           ╭╮╯╭╭─╮╭───╯ ╰╮╰│╮│╯╭│╮╯╰──╯╯╰╮╭╯╭╯│╯╭╯╭╰╮╮╭╯ │╯││││││╭╯╮╰│ ╭╭╯│╭│╭╯
+ 303 ┤╭──────────╯╰╮╭╯│╰╯╭╯│╰─╯│╭╯│╰╮╭╯╰─╯│  ╰╯╰╯╭╯ │╭╯─╯││╭╯╮╭│╰╭╯─╰╰─╯ ╰╯│─╭╯╯╰╯╰╯
+ 292 ┼─╮────────────╯ ╰╯╰╯╰│╭╯ ││ ╰─╰╯╰──╯╰╮╭╯  ││  ╰╯   ╰╰╯ ╰╯╰─╯╯    │╭╯ ╰─╯
+ 282 ┤ ╰─────────╮         ╰╯  ╰╯          ╰╯   ╰╯                     ╰╯
+ 271 ┤           │╭─╮
+ 261 ┤           ╰╯ │  ╭╮                                              ╭╮
+ 250 ┤              ╰╮╭╯╰╮ ╭╮  ╭╮  ╭╮ ╭─╮  ╭╮              ╭╮   ╭─╮   ╭╯│   ╭╮
+ 240 ┤               ││  │╭╯╰╮╭╯│ ╭╯╰╮│ ╰╮ │╰╮  ╭╮   ╭╮   ╭╯╰╮  │ │  ╭╯ ╰╮  ││
+ 229 ┤               ╰╯  ╰╯  ││ ╰╮│  ╰╯  │╭╯ │  ││   │╰╮  │  ╰╮╭╯ ╰╮ │   │ ╭╯╰╮
+ 219 ┤                       ╰╯  ╰╯      ╰╯  ╰╮╭╯╰╮ ╭╯ │ ╭╯   ││   │╭╯   ╰╮│  ╰╮   ╭╮
+ 208 ┤                                        ││  │ │  ╰╮│    ╰╯   ╰╯     ╰╯   │  ╭╯│
+ 198 ┤                                        ╰╯  ╰─╯   ╰╯                     ╰╮ │ ╰
+ 187 ┤                                                                          ╰─╯
                                           replicas
 initial store values: [s1=300, s2=300, s3=300, s4=300, s5=300] (stddev=0.00, mean=300.00, sum=1500)
-last store values: [s1=342, s2=338, s3=339, s4=334, s5=156] (stddev=72.94, mean=301.80, sum=1509)
+last store values: [s1=321, s2=337, s3=323, s4=324, s5=201] (stddev=50.42, mean=301.20, sum=1506)
 
 # Plot the % of disk storage capacity used. We should see s5 hovering right
 # around 92.5-95% (the storage capacity threshold value).
 plot stat=disk_fraction_used
 ----
- 0.98 ┤                ╭╮ ╭╮ ╭─╮ ╭───╮ ╭╮╭╮ ╭╮   ╭╮╭──╮╭╮╭╮   ╭─╮ ╭╮    ╭╮      ╭╮  ╭╮
- 0.91 ┤       ╭────────╯╰─╯╰─╯ ╰─╯   ╰─╯╰╯╰─╯╰───╯╰╯  ╰╯╰╯╰───╯ ╰─╯╰────╯╰──────╯╰──╯╰
- 0.85 ┼───────╯
- 0.78 ┤
- 0.72 ┤
- 0.65 ┤
- 0.59 ┤
- 0.52 ┤
+ 1.14 ┤                                                                      ╭─╮
+ 1.06 ┤                                     ╭╮              ╭╮         ╭─╮   │ │    ╭╮
+ 0.99 ┤         ╭─╮╭─╮  ╭╮ ╭─╮ ╭─╮ ╭─╮ ╭─╮  │╰╮ ╭──╮  ╭─╮  ╭╯╰╮  ╭─╮   │ ╰╮ ╭╯ ╰╮  ╭╯╰
+ 0.91 ┤   ╭─────╯ ╰╯ ╰╮╭╯╰─╯ ╰─╯ ╰╮│ ╰─╯ ╰╮╭╯ ╰╮│  ╰╮╭╯ │ ╭╯  ╰╮╭╯ ╰╮ ╭╯  ╰╮│   ╰──╯
+ 0.84 ┼─╮╭╯           ╰╯          ╰╯      ╰╯   ╰╯   ╰╯  ╰─╯    ╰╯   ╰─╯    ╰╯
+ 0.76 ┤ ╰╯
+ 0.68 ┤
+ 0.61 ┤
+ 0.53 ┤
  0.46 ┤
- 0.39 ┤
- 0.33 ┤
- 0.26 ┤
- 0.20 ┤
- 0.13 ┤
- 0.07 ┤
+ 0.38 ┤
+ 0.30 ┤
+ 0.23 ┤
+ 0.15 ┤
+ 0.08 ┤
  0.00 ┼───────────────────────────────────────────────────────────────────────────────
                                       disk_fraction_used
 initial store values: [s1=0.00, s2=0.00, s3=0.00, s4=0.00, s5=0.83] (stddev=0.33, mean=0.17, sum=1)
-last store values: [s1=0.00, s2=0.00, s3=0.00, s4=0.00, s5=0.94] (stddev=0.38, mean=0.19, sum=1)
+last store values: [s1=0.00, s2=0.00, s3=0.00, s4=0.00, s5=1.02] (stddev=0.41, mean=0.20, sum=1)