Skip to content

Commit b6732b1

Browse files
committed
sql: skip more trivial DDL for schema_locked
Previously, we would enforce schema_locked unecessarily for both zone config modifications and visibility changes on indexes. Since neither of these things imapct CDC, we can safely ignore these operations for schema_locked. This patch adds SetZoneConfig and ALTER INDEX ... VISIBILITY as schema_locked bypassed. Release note: None
1 parent 64d6a47 commit b6732b1

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

pkg/sql/alter_table.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2398,8 +2398,8 @@ func (p *planner) checkSchemaChangeIsAllowed(
23982398
preventedBySchemaLocked = true
23992399
}
24002400
}
2401-
case *tree.AlterIndex, *tree.DropTable, *tree.RenameColumn, *tree.RenameIndex,
2402-
*tree.RenameTable, *tree.AlterTableSetSchema:
2401+
case *tree.AlterIndex, *tree.AlterIndexVisible, *tree.DropTable, *tree.RenameColumn,
2402+
*tree.RenameIndex, *tree.RenameTable, *tree.AlterTableSetSchema, *tree.SetZoneConfig:
24032403
default:
24042404
preventedBySchemaLocked = true
24052405
}

pkg/sql/logictest/testdata/logic_test/schema_locked

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,8 @@ subtest zone_config
179179
statement ok
180180
ALTER TABLE ref SET (schema_locked = true);
181181

182-
onlyif config local-mixed-25.1 local-legacy-schema-changer
183-
statement error pgcode 57000 schema changes are disallowed on table "ref" because it is locked
182+
# This statement is schema_locked bypassed.
183+
statement ok
184184
ALTER TABLE ref CONFIGURE ZONE USING num_replicas = 11;
185185

186186
subtest end

0 commit comments

Comments
 (0)