Skip to content

Commit b9a735e

Browse files
craig[bot]rickystewart
andcommitted
Merge #150452
150452: bazel: don't `lintonbuild` in `ci` configuration r=rail a=rickystewart Due to the way our automation jobs are structured, every job that uses `--config=ci` is post-merge and therefore linting serves no purpose. Disable linting for all these jobs in one fell swoop. Also add comments in `.bazelrc` to fill in some gaps and explain some unintuitive concepts. Epic: none Release note: None Co-authored-by: Ricky Stewart <[email protected]>
2 parents 597bddc + 7cf893d commit b9a735e

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

.bazelrc

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,20 @@ test:race --heavy
6262
# CI uses a custom timeout for enormous targets.
6363
test:use_ci_timeouts --test_timeout=60,300,900,900
6464

65-
# CI should always run with `--config=ci`.
65+
# Some automation should run with `--config=ci`. If using `--config=ci`, it is
66+
# expected you're running the build inside the `bazelbuilder` Docker container
67+
# (see `build/bazelbuilder`), as it will set the `test_tmpdir` to
68+
# `/artifacts/tmp`, a path that probably does not exist on any real machine. The
69+
# configurations in `--config ci` are otherwise generally meant to make log
70+
# output (generally as viewed in TeamCity) more understandable. If adding new
71+
# automation, review the settings that `--config=ci` applies and consider
72+
# whether you need any of these settings.
73+
#
74+
# For builds, `--config=ci` will disable `nogo` -- GitHub Actions Essential CI
75+
# does *not* use `--config=ci` (confusingly) so everything that does use
76+
# `--config=ci` is post-merge, and so it would be slow duplicate work to lint
77+
# everything again.
78+
build:ci --config=nolintonbuild
6679
# Set `-test.v` in Go tests.
6780
# Ref: https://github.com/bazelbuild/rules_go/pull/2456
6881
test:ci --test_env=GO_TEST_WRAP_TESTV=1

0 commit comments

Comments
 (0)