asim: remove run.stateStrAcrossSamples append

wenyihu6 · wenyihu6 · commit ba1a3a7fcad2 · 2025-09-17T22:45:04.000-04:00
This commit removes an unused run.stateStrAcrossSamples append. I left the field
itself in place in the struct since it causes no harm, though we can consider
deleting it entirely.
diff --git a/pkg/kv/kvserver/asim/tests/datadriven_simulation_test.go b/pkg/kv/kvserver/asim/tests/datadriven_simulation_test.go
@@ -539,7 +539,6 @@ func TestDataDriven(t *testing.T) {
 								duration, clusterGen, rangeGen, loadGen,
 								settingsGen, eventGen, seedGen.Int63(), tmpStrB,
 							)
-							run.stateStrAcrossSamples = append(run.stateStrAcrossSamples, simulator.State().String())
 							if stateStrForOnce == "" {
 								stateStrForOnce = tmpStrB.String()
 							}
@@ -698,9 +697,8 @@ func TestDataDriven(t *testing.T) {
 }
 
 type modeHistory struct {
-	mode                  string
-	hs                    []history.History
-	stateStrAcrossSamples []string
+	mode string
+	hs   []history.History
 }
 
 func generateTopology(

Original file line number	Diff line number	Diff line change
`@@ -539,7 +539,6 @@ func TestDataDriven(t *testing.T) {`
`539`	`539`	`duration, clusterGen, rangeGen, loadGen,`
`540`	`540`	`settingsGen, eventGen, seedGen.Int63(), tmpStrB,`
`541`	`541`	`)`
`542`		`- run.stateStrAcrossSamples = append(run.stateStrAcrossSamples, simulator.State().String())`
`543`	`542`	`if stateStrForOnce == "" {`
`544`	`543`	`stateStrForOnce = tmpStrB.String()`
`545`	`544`	`}`
`@@ -698,9 +697,8 @@ func TestDataDriven(t *testing.T) {`
`698`	`697`	`}`
`699`	`698`
`700`	`699`	`type modeHistory struct {`
`701`		`- mode string`
`702`		`- hs []history.History`
`703`		`- stateStrAcrossSamples []string`
	`700`	`+ mode string`
	`701`	`+ hs []history.History`
`704`	`702`	`}`
`705`	`703`
`706`	`704`	`func generateTopology(`