Skip to content

Commit bf4e972

Browse files
committed
server: remove panic
I don't know why this panic is here. If a reviewer happens to know, we can update this to a comment. But, we should be returning this error up the stack so that the user gets a clear error rather than a giant panic. Epic: none Release note: None
1 parent 5fcadbd commit bf4e972

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

pkg/server/server.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -301,9 +301,6 @@ func NewServer(cfg Config, stopper *stop.Stopper) (serverctl.ServerStartupInterf
301301

302302
engines, err := cfg.CreateEngines(ctx)
303303
if err != nil {
304-
if true {
305-
panic(err)
306-
}
307304
return nil, errors.Wrap(err, "failed to create engines")
308305
}
309306
stopper.AddCloser(&engines)

0 commit comments

Comments
 (0)