Skip to content

Commit bf5dd77

Browse files
craig[bot]fqazi
andcommitted
Merge #148407
148407: logictest: deflake zone_config test r=fqazi a=fqazi Previously, the zone_config logic test was flaky because the spans for the table were empty. Which meant the table descriptor could be cleaned up once the sql.gc_job.wait_for_gc.interval timeout was hit. To make tests faster in logictest this defaults to 3 seconds. This patch modifies the test table data, so that the prefix is only empty after GC has occurred. Fixes: #148298 Release note: None Co-authored-by: Faizan Qazi <[email protected]>
2 parents d70ca10 + 06a2ab8 commit bf5dd77

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

pkg/sql/logictest/testdata/logic_test/zone_config

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -301,6 +301,10 @@ CREATE TABLE zc (
301301
b INT
302302
)
303303

304+
# Prevent fast GC with data.
305+
statement ok
306+
INSERT INTO zc VALUES (1,2)
307+
304308
statement ok
305309
ALTER TABLE zc CONFIGURE ZONE USING gc.ttlseconds = 100000
306310

@@ -410,12 +414,20 @@ ALTER DATABASE foo CONFIGURE ZONE USING gc.ttlseconds = 12345
410414
statement ok
411415
CREATE TABLE foo.public.bar (x INT PRIMARY KEY)
412416

417+
# Prevent fast GC with data.
418+
statement ok
419+
INSERT INTO foo.public.bar VALUES (1)
420+
413421
statement ok
414422
DROP DATABASE foo CASCADE
415423

416424
statement ok
417425
CREATE TABLE baz (x INT PRIMARY KEY)
418426

427+
# Prevent fast GC with data.
428+
statement ok
429+
INSERT INTO baz VALUES (1)
430+
419431
statement ok
420432
DROP TABLE baz
421433

0 commit comments

Comments
 (0)