Skip to content

Commit bfef620

Browse files
committed
changefeedccl: improve parallel io metrics
Rename function parameter used to update pending rows metric and y-axis label for that metric to be more accurate. Release note(ops change): Fix changefeed.parallel_io_pending_rows metric y-axis label to match the metric's definition.
1 parent 552cfcb commit bfef620

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

pkg/ccl/changefeedccl/metrics.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -554,8 +554,8 @@ func (k *kafkaHistogramAdapter) Variance() (_ float64) {
554554
}
555555

556556
type parallelIOMetricsRecorder interface {
557-
recordPendingQueuePush(numKeys int64)
558-
recordPendingQueuePop(numKeys int64, latency time.Duration)
557+
recordPendingQueuePush(numMessages int64)
558+
recordPendingQueuePop(numMessages int64, latency time.Duration)
559559
recordResultQueueLatency(latency time.Duration)
560560
setInFlightKeys(n int64)
561561
}
@@ -976,7 +976,7 @@ func newAggregateMetrics(histogramWindow time.Duration, lookup *cidr.Lookup) *Ag
976976
metaChangefeedParallelIOPendingRows := metric.Metadata{
977977
Name: "changefeed.parallel_io_pending_rows",
978978
Help: "Number of rows which are blocked from being sent due to conflicting in-flight keys",
979-
Measurement: "Keys",
979+
Measurement: "Messages",
980980
Unit: metric.Unit_COUNT,
981981
}
982982
metaChangefeedParallelIOResultQueueNanos := metric.Metadata{

0 commit comments

Comments
 (0)