Skip to content

Commit c013c36

Browse files
craig[bot]rharding6373
andcommitted
Merge #152678
152678: changefeedccl: mark description as safe for log redaction r=aerfrei a=rharding6373 Previously, logs in maybeLogBehindSpan would mark the description string (i.e., coordinator or aggregator) as redactable. This is not sensitive information, so it should not be redacted. Epic: none Release note: none Co-authored-by: rharding6373 <[email protected]>
2 parents b66aafa + 3f3a0a0 commit c013c36

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/ccl/changefeedccl/changefeed_processors.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2246,12 +2246,12 @@ func maybeLogBehindSpan(
22462246

22472247
if frontierChanged && slowLogEveryN.ShouldProcess(now) {
22482248
log.Dev.Infof(ctx, "%s new resolved timestamp %s is behind by %s",
2249-
description, frontierTS, resolvedBehind)
2249+
redact.Safe(description), frontierTS, resolvedBehind)
22502250
}
22512251

22522252
if slowLogEveryN.ShouldProcess(now) {
22532253
s := frontier.PeekFrontierSpan()
2254-
log.Dev.Infof(ctx, "%s span %s is behind by %s", description, s, resolvedBehind)
2254+
log.Dev.Infof(ctx, "%s span %s is behind by %s", redact.Safe(description), s, resolvedBehind)
22552255
}
22562256
}
22572257

0 commit comments

Comments
 (0)