Skip to content

Commit c017656

Browse files
committed
roachtest: disable skip upgrades for rebalance load mixed version tests
There is a known edge case in the mixed version framework when there is only one upgrade that can run user hooks (25.1 -> 25.2) and the fromVersion (25.1) is skippable. The framework always enforces at least one skip upgrade if enabled (24.3 -> 25.2), which would lead to zero upgrades running user hooks. Instead, disable skip upgrades.
1 parent a99e71a commit c017656

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

pkg/cmd/roachtest/tests/rebalance_load.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,13 @@ func registerRebalanceLoad(r registry.Registry) {
110110
),
111111
// Only use the latest version of each release to work around #127029.
112112
mixedversion.AlwaysUseLatestPredecessors,
113+
// There is a known edge case in the mixed version framework when there
114+
// is only one upgrade that can run user hooks (25.1 -> 25.2) and the
115+
// fromVersion (25.1) is skippable. The framework always enforces at
116+
// least one skip upgrade if enabled (24.3 -> 25.2), which would lead to
117+
// zero upgrades running user hooks. Instead, disable skip upgrades.
118+
// TODO(#151408): Remove when the framework handles this case.
119+
mixedversion.DisableSkipVersionUpgrades,
113120
// There have been many performance improvements in versions 25.1.0+.
114121
// In particular, the CPU utilization attributed to SQL can vary
115122
// significantly between versions, which can lead to flakiness in these

0 commit comments

Comments
 (0)