Merge #143849 #143985 #144000 #144037 #144050 #144088

143849: backup: add checkpointing to backup compactions r=msbutler a=kev-cao

This patch adds periodic checkpointing to backup compaction jobs.

Epic: None

Release note: None

143985: backup: checkpoint after online restore link phase r=msbutler a=msbutler

This patch will prevent online restore from rerunning the link flow if it has already completed. This will be useful for restore with experimental copy, which runs the download phase in the same job as the link phase. At some point in the future, we could add finer grain checkpointing to the link phase, but that would require more work and thought.

Epic: none

Release note: none

144000: orchestration: released CockroachDB version 25.1.3. Next version: 25.1.4 r=celiala a=cockroach-teamcity


Release note: None
Epic: None
Release justification: non-production (release infra) change.


144037: sql/stats: bring back guard against non-zero NumRange in forecasts r=yuzefovich a=michae2

It occurred to me tonight that the code we removed in #143955 not only generated a sentry report, but also returned an error instead of producing a faulty histogram. I too hope that #93892 is now fixed, but it seems wise to at least keep some code that guards against faulty histograms, even if we don't think the sentry report is necessary any more.

Informs: #93892

Epic: None

Release note: None

144050: dr: alias streaming replication to PCR r=msbutler a=ajstorm

Add an alias in the original Streaming Replication Between Clusters RFC to PCR, for easier discovery.

I can see an argument for not merging this, as the original RFC might not bare resemblance to what was built in the end, but the RFC is basically undiscoverable today due to its antiquated naming.

Epic: none
Release note: None

144088: ci: prioritize `staging-*` builds higher r=jlinder a=rickystewart

These builds are high-priority backports and we want them to get through the queue as quickly as possible.

Epic: DEVINF-1449
Release note: None

Co-authored-by: Kevin Cao <[email protected]>
Co-authored-by: Michael Butler <[email protected]>
Co-authored-by: Justin Beaver <[email protected]>
Co-authored-by: Michael Erickson <[email protected]>
Co-authored-by: Adam Storm <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>

Author: 7 people

build/github/engflow-args.sh

@@ -10,7 +10,10 @@
 
 ARGS='--config engflowpublic --tls_client_certificate=/home/agent/engflow.crt --tls_client_key=/home/agent/engflow.key --experimental_build_event_upload_retry_minimum_delay 3s --experimental_build_event_upload_max_retries 8'
 
-if [ "$GITHUB_ACTIONS_BRANCH" == "staging" ]
+if [[ "$GITHUB_ACTIONS_BRANCH" == staging-* ]]
+then
+    ARGS="$ARGS --remote_execution_priority=8"
+elif [ "$GITHUB_ACTIONS_BRANCH" == "staging" ]
 then
     ARGS="$ARGS --remote_execution_priority=6"
 fi

cloud/kubernetes/bring-your-own-certs/client.yaml

@@ -20,7 +20,7 @@ spec:
   serviceAccountName: cockroachdb
   containers:
   - name: cockroachdb-client
-    image: cockroachdb/cockroach:v25.1.2
+    image: cockroachdb/cockroach:v25.1.3
     # Keep a pod open indefinitely so kubectl exec can be used to get a shell to it
     # and run cockroach client commands, such as cockroach sql, cockroach node status, etc.
     command:

cloud/kubernetes/bring-your-own-certs/cockroachdb-statefulset.yaml

@@ -153,7 +153,7 @@ spec:
               topologyKey: kubernetes.io/hostname
       containers:
       - name: cockroachdb
-        image: cockroachdb/cockroach:v25.1.2
+        image: cockroachdb/cockroach:v25.1.3
         imagePullPolicy: IfNotPresent
         # TODO: Change these to appropriate values for the hardware that you're running. You can see
         # the resources that can be allocated on each of your Kubernetes nodes by running:

cloud/kubernetes/client-secure.yaml

@@ -32,7 +32,7 @@ spec:
       mountPath: /cockroach-certs
   containers:
   - name: cockroachdb-client
-    image: cockroachdb/cockroach:v25.1.2
+    image: cockroachdb/cockroach:v25.1.3
     imagePullPolicy: IfNotPresent
     volumeMounts:
     - name: client-certs

cloud/kubernetes/cluster-init-secure.yaml

@@ -34,7 +34,7 @@ spec:
           mountPath: /cockroach-certs
       containers:
       - name: cluster-init
-        image: cockroachdb/cockroach:v25.1.2
+        image: cockroachdb/cockroach:v25.1.3
         imagePullPolicy: IfNotPresent
         volumeMounts:
         - name: client-certs

cloud/kubernetes/cluster-init.yaml

@@ -10,7 +10,7 @@ spec:
     spec:
       containers:
       - name: cluster-init
-        image: cockroachdb/cockroach:v25.1.2
+        image: cockroachdb/cockroach:v25.1.3
         imagePullPolicy: IfNotPresent
         command:
           - "/cockroach/cockroach"

cloud/kubernetes/cockroachdb-statefulset-secure.yaml

@@ -195,7 +195,7 @@ spec:
               topologyKey: kubernetes.io/hostname
       containers:
       - name: cockroachdb
-        image: cockroachdb/cockroach:v25.1.2
+        image: cockroachdb/cockroach:v25.1.3
         imagePullPolicy: IfNotPresent
         # TODO: Change these to appropriate values for the hardware that you're running. You can see
         # the resources that can be allocated on each of your Kubernetes nodes by running:

cloud/kubernetes/cockroachdb-statefulset.yaml

@@ -98,7 +98,7 @@ spec:
               topologyKey: kubernetes.io/hostname
       containers:
       - name: cockroachdb
-        image: cockroachdb/cockroach:v25.1.2
+        image: cockroachdb/cockroach:v25.1.3
         imagePullPolicy: IfNotPresent
         # TODO: Change these to appropriate values for the hardware that you're running. You can see
         # the resources that can be allocated on each of your Kubernetes nodes by running:

cloud/kubernetes/multiregion/client-secure.yaml

@@ -9,7 +9,7 @@ spec:
   serviceAccountName: cockroachdb
   containers:
   - name: cockroachdb-client
-    image: cockroachdb/cockroach:v25.1.2
+    image: cockroachdb/cockroach:v25.1.3
     imagePullPolicy: IfNotPresent
     volumeMounts:
     - name: client-certs

cloud/kubernetes/multiregion/cluster-init-secure.yaml

@@ -11,7 +11,7 @@ spec:
       serviceAccountName: cockroachdb
       containers:
       - name: cluster-init
-        image: cockroachdb/cockroach:v25.1.2
+        image: cockroachdb/cockroach:v25.1.3
         imagePullPolicy: IfNotPresent
         volumeMounts:
         - name: client-certs