kvserver: return an assertion error instead of panic

tbg · tbg · commit c43b380cff42 · 2025-07-31T13:12:12.000+02:00
diff --git a/pkg/kv/kvserver/kvstorage/init.go b/pkg/kv/kvserver/kvstorage/init.go
@@ -299,7 +299,7 @@ func IterateRangeDescriptorsFromDisk(
 				// This case shouldn't happen in practice: we have a key that isn't
 				// associated with any range descriptor.
 				if buildutil.CrdbTestBuild {
-					panic(errors.AssertionFailedf("range local key %s outside of a known range", key.Key))
+					return errors.AssertionFailedf("range local key %s outside of a known range", key.Key)
 				}
 				iter.NextKey()
 			}

Original file line number	Diff line number	Diff line change
`@@ -299,7 +299,7 @@ func IterateRangeDescriptorsFromDisk(`
`299`	`299`	`// This case shouldn't happen in practice: we have a key that isn't`
`300`	`300`	`// associated with any range descriptor.`
`301`	`301`	`if buildutil.CrdbTestBuild {`
`302`		`- panic(errors.AssertionFailedf("range local key %s outside of a known range", key.Key))`
	`302`	`+ return errors.AssertionFailedf("range local key %s outside of a known range", key.Key)`
`303`	`303`	`}`
`304`	`304`	`iter.NextKey()`
`305`	`305`	`}`