Merge #141193

141193: Implement types.Any variadic function handling r=mw5h a=mw5h

#### builtins: Change pg_column_size from Immutable to Stable

pg_column_size() is Stable in Postgres, not Immutable.

Epic: none
Release note: none

#### types: reintroduce the 'any' type

In a previous commit, we converted all usages of the old types.Any to
types.AnyElement, which reflects our legacy use of type.Any. This patch
reintroduces types.Any, which is similar to types.AnyElement, but does
not require all instances of types.Any in a function's argument list to
have the same type (i.e. it's a true wildcard).

Future patches will evaluate whether individual uses of types.AnyElement
should really be using types.Any. For reference, types.Any should be
used whenever the type of a expression is truly unconstrained.

Informs: #136295
Release note: None

#### tree: handle builtin overloads with types.Any variadic arguments

Previously, variadic argument lists with types.Any variable arguments
were being processed as types.AnyElement. An earlier patch changed these
instances to types.AnyElement, correcting this error. This patch now
takes the reintroduced types.Any (unconstrained wildcard) and makes it
available for builtin functions. Much of the overload selection process
is constraining untyped arguments to make variadic types.AnyElement
work, so the implementation here is an early special case to avoid that
processing.

Informs: #136295
Release note: None

#### builtins: change concat() to take types.Any arguments

Previously, concat() took a variable argument list of types.AnyElement.
This patch changes the argument type to types.Any and updates some
related tests.

Fixes: #136295
Release note (sql change): concat() no longer requires all arguments
have the same type.

#### builtins: change num_nulls()/num_notnulls() to take types.Any arguments

Previously, num_nulls() and num_notnulls() required all arguments to
have the same type. This patch removes that restriction.

Epic: none
Release note (sql change): num_nulls and num_notnulls() no longer
require all arguments to have the same type.

#### builtins: change format() to accept types.Any arguments

Previously, format() required all arguments after the format string to
have the same argument type. This patch removes that restriction.

Release note (sql change): format() no longer requires all post-format
string arguments to have the same type.

#### builtins: change crdb_internal.datums_to_bytes() to accept types.Any

Previously, crdb_internal.datums_to_bytes() required all arguments to
have the same type. This patch removes that restriction to allow
arguments of any type.

Release note: None

#### builtins: change concat_ws() to accept arguments of types.Any type

Previously, concat_ws() required all arguments to be of type string,
this patch changes the requirement such that the first argument (the
delimiter) must be a string but that all follow-on arguments may be of
any type.

Release note (sql change): concat_ws() now accepts arguments of any type
in the second and later positions (the separator must still be a
string).

#### builtins: change json_build_objects/array() to accept types.Any

Previously, json_build_objects() and json_build_array() (and their
binary variants) required that all arguments have the same type. This
patch removes that requirement so that arguments can be of any type.

Epic: none
Release note (sql change): json_build_objects(), jsonb_build_objects(),
json_build_array(), jsonb_build_array() no longer require that all
arguments have the same type.

#### builtins: change pg_column_size() to accepts arguments of types.Any

Previously, pg_column_size() required that all arguments have the same
type. This patch removes that restriction so that every argument can
have a different type.

Epic: none
Release note (sql change): pg_column_size() no longer requires that all
arguments have the same type.


Co-authored-by: Matt White <[email protected]>

Author: craig[bot]

docs/generated/sql/functions.md

@@ -439,9 +439,9 @@
 </span></td><td>Immutable</td></tr>
 <tr><td><a name="least"></a><code>least(anyelement...) &rarr; anyelement</code></td><td><span class="funcdesc"><p>Returns the element with the lowest value.</p>
 </span></td><td>Immutable</td></tr>
-<tr><td><a name="num_nonnulls"></a><code>num_nonnulls(anyelement...) &rarr; <a href="int.html">int</a></code></td><td><span class="funcdesc"><p>Returns the number of nonnull arguments.</p>
+<tr><td><a name="num_nonnulls"></a><code>num_nonnulls(any...) &rarr; <a href="int.html">int</a></code></td><td><span class="funcdesc"><p>Returns the number of nonnull arguments.</p>
 </span></td><td>Immutable</td></tr>
-<tr><td><a name="num_nulls"></a><code>num_nulls(anyelement...) &rarr; <a href="int.html">int</a></code></td><td><span class="funcdesc"><p>Returns the number of null arguments.</p>
+<tr><td><a name="num_nulls"></a><code>num_nulls(any...) &rarr; <a href="int.html">int</a></code></td><td><span class="funcdesc"><p>Returns the number of null arguments.</p>
 </span></td><td>Immutable</td></tr></tbody>
 </table>
 
@@ -1180,9 +1180,9 @@ available replica will error.</p>
 </span></td><td>Immutable</td></tr>
 <tr><td><a name="json_array_length"></a><code>json_array_length(json: jsonb) &rarr; <a href="int.html">int</a></code></td><td><span class="funcdesc"><p>Returns the number of elements in the outermost JSON or JSONB array.</p>
 </span></td><td>Immutable</td></tr>
-<tr><td><a name="json_build_array"></a><code>json_build_array(anyelement...) &rarr; jsonb</code></td><td><span class="funcdesc"><p>Builds a possibly-heterogeneously-typed JSON or JSONB array out of a variadic argument list.</p>
+<tr><td><a name="json_build_array"></a><code>json_build_array(any...) &rarr; jsonb</code></td><td><span class="funcdesc"><p>Builds a possibly-heterogeneously-typed JSON or JSONB array out of a variadic argument list.</p>
 </span></td><td>Stable</td></tr>
-<tr><td><a name="json_build_object"></a><code>json_build_object(anyelement...) &rarr; jsonb</code></td><td><span class="funcdesc"><p>Builds a JSON object out of a variadic argument list.</p>
+<tr><td><a name="json_build_object"></a><code>json_build_object(any...) &rarr; jsonb</code></td><td><span class="funcdesc"><p>Builds a JSON object out of a variadic argument list.</p>
 </span></td><td>Stable</td></tr>
 <tr><td><a name="json_each"></a><code>json_each(input: jsonb) &rarr; tuple{string AS key, jsonb AS value}</code></td><td><span class="funcdesc"><p>Expands the outermost JSON or JSONB object into a set of key/value pairs.</p>
 </span></td><td>Immutable</td></tr>
@@ -1218,9 +1218,9 @@ available replica will error.</p>
 </span></td><td>Immutable</td></tr>
 <tr><td><a name="jsonb_array_length"></a><code>jsonb_array_length(json: jsonb) &rarr; <a href="int.html">int</a></code></td><td><span class="funcdesc"><p>Returns the number of elements in the outermost JSON or JSONB array.</p>
 </span></td><td>Immutable</td></tr>
-<tr><td><a name="jsonb_build_array"></a><code>jsonb_build_array(anyelement...) &rarr; jsonb</code></td><td><span class="funcdesc"><p>Builds a possibly-heterogeneously-typed JSON or JSONB array out of a variadic argument list.</p>
+<tr><td><a name="jsonb_build_array"></a><code>jsonb_build_array(any...) &rarr; jsonb</code></td><td><span class="funcdesc"><p>Builds a possibly-heterogeneously-typed JSON or JSONB array out of a variadic argument list.</p>
 </span></td><td>Stable</td></tr>
-<tr><td><a name="jsonb_build_object"></a><code>jsonb_build_object(anyelement...) &rarr; jsonb</code></td><td><span class="funcdesc"><p>Builds a JSON object out of a variadic argument list.</p>
+<tr><td><a name="jsonb_build_object"></a><code>jsonb_build_object(any...) &rarr; jsonb</code></td><td><span class="funcdesc"><p>Builds a JSON object out of a variadic argument list.</p>
 </span></td><td>Stable</td></tr>
 <tr><td><a name="jsonb_each"></a><code>jsonb_each(input: jsonb) &rarr; tuple{string AS key, jsonb AS value}</code></td><td><span class="funcdesc"><p>Expands the outermost JSON or JSONB object into a set of key/value pairs.</p>
 </span></td><td>Immutable</td></tr>
@@ -2912,9 +2912,9 @@ Can be used to define the tile bounds required by ST_AsMVTGeom to convert geomet
 </span></td><td>Immutable</td></tr>
 <tr><td><a name="compress"></a><code>compress(data: <a href="bytes.html">bytes</a>, codec: <a href="string.html">string</a>) &rarr; <a href="bytes.html">bytes</a></code></td><td><span class="funcdesc"><p>Compress <code>data</code> with the specified <code>codec</code> (<code>gzip</code>, ‘lz4’, ‘snappy’, 'zstd).</p>
 </span></td><td>Immutable</td></tr>
-<tr><td><a name="concat"></a><code>concat(anyelement...) &rarr; <a href="string.html">string</a></code></td><td><span class="funcdesc"><p>Concatenates a comma-separated list of strings.</p>
+<tr><td><a name="concat"></a><code>concat(any...) &rarr; <a href="string.html">string</a></code></td><td><span class="funcdesc"><p>Concatenates a comma-separated list of strings.</p>
 </span></td><td>Immutable</td></tr>
-<tr><td><a name="concat_ws"></a><code>concat_ws(<a href="string.html">string</a>...) &rarr; <a href="string.html">string</a></code></td><td><span class="funcdesc"><p>Uses the first argument as a separator between the concatenation of the subsequent arguments.</p>
+<tr><td><a name="concat_ws"></a><code>concat_ws(<a href="string.html">string</a>, any...) &rarr; <a href="string.html">string</a></code></td><td><span class="funcdesc"><p>Uses the first argument as a separator between the concatenation of the subsequent arguments.</p>
 <p>For example <code>concat_ws('!','wow','great')</code> returns <code>wow!great</code>.</p>
 </span></td><td>Immutable</td></tr>
 <tr><td><a name="convert_from"></a><code>convert_from(str: <a href="bytes.html">bytes</a>, enc: <a href="string.html">string</a>) &rarr; <a href="string.html">string</a></code></td><td><span class="funcdesc"><p>Decode the bytes in <code>str</code> into a string using encoding <code>enc</code>. Supports encodings ‘UTF8’ and ‘LATIN1’.</p>
@@ -2929,7 +2929,7 @@ Can be used to define the tile bounds required by ST_AsMVTGeom to convert geomet
 </span></td><td>Immutable</td></tr>
 <tr><td><a name="encode"></a><code>encode(data: <a href="bytes.html">bytes</a>, format: <a href="string.html">string</a>) &rarr; <a href="string.html">string</a></code></td><td><span class="funcdesc"><p>Encodes <code>data</code> using <code>format</code> (<code>hex</code> / <code>escape</code> / <code>base64</code>).</p>
 </span></td><td>Immutable</td></tr>
-<tr><td><a name="format"></a><code>format(<a href="string.html">string</a>, anyelement...) &rarr; <a href="string.html">string</a></code></td><td><span class="funcdesc"><p>Interprets the first argument as a format string similar to C sprintf and interpolates the remaining arguments.</p>
+<tr><td><a name="format"></a><code>format(<a href="string.html">string</a>, any...) &rarr; <a href="string.html">string</a></code></td><td><span class="funcdesc"><p>Interprets the first argument as a format string similar to C sprintf and interpolates the remaining arguments.</p>
 </span></td><td>Stable</td></tr>
 <tr><td><a name="from_ip"></a><code>from_ip(val: <a href="bytes.html">bytes</a>) &rarr; <a href="string.html">string</a></code></td><td><span class="funcdesc"><p>Converts the byte string representation of an IP to its character string representation.</p>
 </span></td><td>Immutable</td></tr>
@@ -3500,8 +3500,8 @@ may increase either contention or retry errors, or both.</p>
 </span></td><td>Stable</td></tr>
 <tr><td><a name="pg_column_is_updatable"></a><code>pg_column_is_updatable(reloid: oid, attnum: int2, include_triggers: <a href="bool.html">bool</a>) &rarr; <a href="bool.html">bool</a></code></td><td><span class="funcdesc"><p>Returns whether the given column can be updated.</p>
 </span></td><td>Stable</td></tr>
-<tr><td><a name="pg_column_size"></a><code>pg_column_size(anyelement...) &rarr; <a href="int.html">int</a></code></td><td><span class="funcdesc"><p>Return size in bytes of the column provided as an argument</p>
-</span></td><td>Immutable</td></tr>
+<tr><td><a name="pg_column_size"></a><code>pg_column_size(any...) &rarr; <a href="int.html">int</a></code></td><td><span class="funcdesc"><p>Return size in bytes of the column provided as an argument</p>
+</span></td><td>Stable</td></tr>
 <tr><td><a name="pg_function_is_visible"></a><code>pg_function_is_visible(oid: oid) &rarr; <a href="bool.html">bool</a></code></td><td><span class="funcdesc"><p>Returns whether the function with the given OID belongs to one of the schemas on the search path.</p>
 </span></td><td>Stable</td></tr>
 <tr><td><a name="pg_get_function_arg_default"></a><code>pg_get_function_arg_default(func_oid: oid, arg_num: int4) &rarr; <a href="string.html">string</a></code></td><td><span class="funcdesc"><p>Get textual representation of a function argument’s default value. The second argument of this function is the argument number among all arguments (i.e. proallargtypes, <em>not</em> proargtypes), starting with 1, because that’s how information_schema.sql uses it. Currently, this always returns NULL, since CockroachDB does not support default values.</p>

pkg/kv/kvserver/replicate_queue_test.go

@@ -1757,7 +1757,7 @@ func filterRangeLog(
 	eventType kvserverpb.RangeLogEventType,
 	reason kvserverpb.RangeLogEventReason,
 ) ([]kvserverpb.RangeLogEvent_Info, error) {
-	return queryRangeLog(conn, `SELECT info FROM system.rangelog WHERE "rangeID" = $1 AND "eventType" = $2 AND info LIKE concat('%', $3, '%') ORDER BY timestamp ASC;`, rangeID, eventType.String(), reason)
+	return queryRangeLog(conn, `SELECT info FROM system.rangelog WHERE "rangeID" = $1 AND "eventType" = $2 AND info LIKE concat('%', $3::STRING, '%') ORDER BY timestamp ASC;`, rangeID, eventType.String(), reason)
 }
 
 func toggleReplicationQueues(tc *testcluster.TestCluster, active bool) {

pkg/sql/logictest/testdata/logic_test/builtin_function

@@ -203,6 +203,14 @@ SELECT concat('foo'::concat_enum, ' ', 64.532, ' ', 'baz'::concat_enum, ' ', 42,
 ----
 foo 64.532 baz 42 f {"foo": "bar"} {1,2,3}
 
+statement ok
+PREPARE concat_stmt AS SELECT concat("foo"."a", $1::STRING) FROM foo
+
+query T
+EXECUTE concat_stmt(':')
+----
+1:
+
 query T
 SELECT substr('RoacH', 2, 3)
 ----
@@ -420,8 +428,10 @@ SELECT concat_ws(',', 'abcde', '2')
 ----
 abcde,2
 
-statement error unknown signature: concat_ws\(string, string, int, unknown, int\)
+query T
 SELECT concat_ws(',', 'abcde', 2, NULL, 22)
+----
+abcde,2,22
 
 query T
 SELECT split_part('abc~@~def~@~ghi', '~@~', 2)
@@ -2672,6 +2682,19 @@ SELECT format('|%-*s|', -10, 'foo')
 ----
 |foo       |
 
+statement
+PREPARE format_stmt AS SELECT format('|%*s|', $1::INT, $2::STRING)
+
+query T
+EXECUTE format_stmt(10, 'foo')
+----
+|       foo|
+
+query T
+EXECUTE format_stmt(-10, 'foo')
+----
+|foo       |
+
 # Escaping $ into \x24 only needed in testlogic or prepared statements
 query T
 SELECT format(E'Testing %3\x24s, %2\x24s, %1\x24s', 'one', 'two', 'three')
@@ -3055,6 +3078,33 @@ SELECT num_nulls(a, b), num_nonnulls(a, b) FROM nulls_test
 1  1
 2  0
 
+statement ok
+PREPARE nn_stmt AS SELECT num_nulls(42, $1::STRING, a, b),
+                          num_nulls(b, $1, 42, a),
+                          num_nulls(a, b, $1, 42),
+                          num_nulls($1, a, b, 42),
+                          num_nonnulls(42, $1, a, b),
+                          num_nonnulls(b, $1, 42, a),
+                          num_nonnulls(a, b, $1, 42),
+                          num_nonnulls($1, a, b, 42)
+                     FROM nulls_test
+
+query IIIIIIII rowsort
+EXECUTE nn_stmt(NULL)
+----
+1  1  1  1  3  3  3  3
+2  2  2  2  2  2  2  2
+2  2  2  2  2  2  2  2
+3  3  3  3  1  1  1  1
+
+query IIIIIIII rowsort
+EXECUTE nn_stmt('foo')
+----
+0  0  0  0  4  4  4  4
+1  1  1  1  3  3  3  3
+1  1  1  1  3  3  3  3
+2  2  2  2  2  2  2  2
+
 subtest pb_to_json
 
 query T

pkg/sql/logictest/testdata/logic_test/computed

@@ -357,7 +357,7 @@ CREATE TABLE y (
   c TIMESTAMPTZ AS (a+ b) STORED
 )
 
-statement error concat\(\): uuid_v4\(\): volatile functions are not allowed in STORED COMPUTED COLUMN
+statement error pq: concat\(\): error type checking resolved expression:: uuid_v4\(\): volatile functions are not allowed in STORED COMPUTED COLUMN
 CREATE TABLE y (
   a STRING AS (concat('foo', uuid_v4()::STRING)) STORED
 )

pkg/sql/logictest/testdata/logic_test/grant_table

@@ -122,6 +122,9 @@ test           pg_catalog          "char"                                 type
 test           pg_catalog          "char"[]                               type         admin    ALL             false
 test           pg_catalog          "char"[]                               type         public   USAGE           false
 test           pg_catalog          "char"[]                               type         root     ALL             false
+test           pg_catalog          any                                    type         admin    ALL             false
+test           pg_catalog          any                                    type         public   USAGE           false
+test           pg_catalog          any                                    type         root     ALL             false
 test           pg_catalog          anyarray                               type         admin    ALL             false
 test           pg_catalog          anyarray                               type         public   USAGE           false
 test           pg_catalog          anyarray                               type         root     ALL             false
@@ -537,6 +540,8 @@ test           pg_catalog   "char"          type         admin    ALL
 test           pg_catalog   "char"          type         root     ALL             false
 test           pg_catalog   "char"[]        type         admin    ALL             false
 test           pg_catalog   "char"[]        type         root     ALL             false
+test           pg_catalog   any             type         admin    ALL             false
+test           pg_catalog   any             type         root     ALL             false
 test           pg_catalog   anyarray        type         admin    ALL             false
 test           pg_catalog   anyarray        type         root     ALL             false
 test           pg_catalog   anyelement      type         admin    ALL             false
@@ -787,6 +792,8 @@ a              pg_catalog   "char"          type         admin    ALL
 a              pg_catalog   "char"          type         root     ALL             false
 a              pg_catalog   "char"[]        type         admin    ALL             false
 a              pg_catalog   "char"[]        type         root     ALL             false
+a              pg_catalog   any             type         admin    ALL             false
+a              pg_catalog   any             type         root     ALL             false
 a              pg_catalog   anyarray        type         admin    ALL             false
 a              pg_catalog   anyarray        type         root     ALL             false
 a              pg_catalog   anyelement      type         admin    ALL             false
@@ -975,6 +982,8 @@ defaultdb      pg_catalog   "char"          type         admin    ALL
 defaultdb      pg_catalog   "char"          type         root     ALL             false
 defaultdb      pg_catalog   "char"[]        type         admin    ALL             false
 defaultdb      pg_catalog   "char"[]        type         root     ALL             false
+defaultdb      pg_catalog   any             type         admin    ALL             false
+defaultdb      pg_catalog   any             type         root     ALL             false
 defaultdb      pg_catalog   anyarray        type         admin    ALL             false
 defaultdb      pg_catalog   anyarray        type         root     ALL             false
 defaultdb      pg_catalog   anyelement      type         admin    ALL             false
@@ -1163,6 +1172,8 @@ postgres       pg_catalog   "char"          type         admin    ALL
 postgres       pg_catalog   "char"          type         root     ALL             false
 postgres       pg_catalog   "char"[]        type         admin    ALL             false
 postgres       pg_catalog   "char"[]        type         root     ALL             false
+postgres       pg_catalog   any             type         admin    ALL             false
+postgres       pg_catalog   any             type         root     ALL             false
 postgres       pg_catalog   anyarray        type         admin    ALL             false
 postgres       pg_catalog   anyarray        type         root     ALL             false
 postgres       pg_catalog   anyelement      type         admin    ALL             false
@@ -1359,6 +1370,8 @@ test           pg_catalog   "char"          type         admin    ALL
 test           pg_catalog   "char"          type         root     ALL             false
 test           pg_catalog   "char"[]        type         admin    ALL             false
 test           pg_catalog   "char"[]        type         root     ALL             false
+test           pg_catalog   any             type         admin    ALL             false
+test           pg_catalog   any             type         root     ALL             false
 test           pg_catalog   anyarray        type         admin    ALL             false
 test           pg_catalog   anyarray        type         root     ALL             false
 test           pg_catalog   anyelement      type         admin    ALL             false

pkg/sql/logictest/testdata/logic_test/json_builtins

@@ -562,6 +562,20 @@ SELECT json_build_object('a', '0100110'::varbit)
 ----
 {"a": "0100110"}
 
+statement ok
+CREATE TABLE foo (a INT);
+
+statement ok
+INSERT INTO foo VALUES (42);
+
+statement ok
+PREPARE jbo_stmt AS SELECT json_build_object('a', a, 'b', $1::STRING) FROM foo;
+
+query T
+EXECUTE jbo_stmt(':');
+----
+{"a": 42, "b": ":"}
+
 # Regression for an internal error when using an enum and void in the key.
 statement ok
 CREATE TYPE e AS ENUM ('e');
@@ -713,6 +727,14 @@ SELECT json_build_array(1, '1'::JSON, 1.2, NULL, ARRAY['x', 'y'])
 ----
 [1, 1, 1.2, null, ["x", "y"]]
 
+statement ok
+PREPARE jba_stmt AS SELECT json_build_array(a, $1::STRING) FROM foo;
+
+query T
+EXECUTE jba_stmt(':');
+----
+[42, ":"]
+
 query T
 SELECT jsonb_build_array()
 ----