Skip to content

Commit c67361d

Browse files
committed
roachtest: disable use_soft_limit_for_distribute_scan in bulk ingest test
Temporarily disable use_soft_limit_for_distribute_scan in the schema change bulk ingest test to validate that this setting is the root cause of the performance regression observed in issue #152859. It is suspected that the regression occurred due to commit dd57482, which change the default value of use_soft_limit_for_distribute_scan. This just changes the setting back to its original default to verify. Informs #152859 Release note: None
1 parent 523a78d commit c67361d

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

pkg/cmd/roachtest/tests/schemachange.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -433,6 +433,13 @@ func makeSchemaChangeBulkIngestTest(
433433
db := c.Conn(ctx, t.L(), 1)
434434
defer db.Close()
435435

436+
// TODO(152859): Temporarily disable soft limit for distribute scan to
437+
// test performance regression fix (see #152295).
438+
t.L().Printf("Setting use_soft_limit_for_distribute_scan = false")
439+
if _, err := db.Exec("SET use_soft_limit_for_distribute_scan = false"); err != nil {
440+
t.Fatal(err)
441+
}
442+
436443
t.L().Printf("Computing table statistics manually")
437444
if _, err := db.Exec("CREATE STATISTICS stats from bulkingest.bulkingest"); err != nil {
438445
t.Fatal(err)

0 commit comments

Comments
 (0)