Merge #148014

148014: sql: skip inverted indexes in show fingerprints r=jeffswenson a=jeffswenson

SHOW EXPERIMENTAL_FINGERPRINTS is used by the DR team to validate tables
replicated via logical replication. It validates indexes by crafting a
SQL query that forces the use of the index via hints. This doesn't work
for inverted indexes, since each row can have multiple entries in the
inverted index. This PR changes the fingerprinting logic so that it
ignores the incompatible indexes instead of failing to execute.

Release note: none
Informs: CRDB-44094

Co-authored-by: Jeff Swenson <[email protected]>

Author: craig[bot]

pkg/sql/show_fingerprints.go

@@ -25,6 +25,7 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/sql/privilege"
 	"github.com/cockroachdb/cockroach/pkg/sql/sem/asof"
 	"github.com/cockroachdb/cockroach/pkg/sql/sem/eval"
+	"github.com/cockroachdb/cockroach/pkg/sql/sem/idxtype"
 	"github.com/cockroachdb/cockroach/pkg/sql/sem/tree"
 	"github.com/cockroachdb/cockroach/pkg/sql/sessiondata"
 	"github.com/cockroachdb/cockroach/pkg/sql/sessionprotectedts"
@@ -313,6 +314,14 @@ func (n *showFingerprintsNode) Next(params runParams) (bool, error) {
 		return false, nil
 	}
 	index := n.indexes[n.run.rowIdx]
+
+	// Skip inverted indexes. Experimental fingerprint uses a query that forces
+	// the use of an index and that is incompatible with inverted indexes.
+	if index.GetType() == idxtype.INVERTED {
+		n.run.rowIdx++
+		return n.Next(params)
+	}
+
 	excludedColumns := []string{}
 	if n.options != nil && len(n.options.excludedUserColumns) > 0 {
 		excludedColumns = append(excludedColumns, n.options.excludedUserColumns...)

pkg/sql/show_fingerprints_test.go

@@ -95,6 +95,37 @@ func TestShowFingerprintsColumnNames(t *testing.T) {
 	}
 }
 
+func TestShowFingerprintInvertedIndex(t *testing.T) {
+	defer leaktest.AfterTest(t)()
+	defer log.Scope(t).Close(t)
+
+	ctx := context.Background()
+	tc := serverutils.StartCluster(t, 1, base.TestClusterArgs{})
+	defer tc.Stopper().Stop(ctx)
+
+	sqlDB := sqlutils.MakeSQLRunner(tc.ServerConn(0))
+	sqlDB.Exec(t, `CREATE DATABASE d`)
+	sqlDB.Exec(t, `CREATE TABLE d.t (
+		a INT PRIMARY KEY,
+		b INT,
+		c INT,
+		d JSONB,
+		INDEX b_idx (b),
+		INDEX c_partial_idx (c) WHERE c > 0,
+		INVERTED INDEX d_inverted_idx (d)
+	)`)
+
+	sqlDB.Exec(t, `INSERT INTO d.t VALUES (1, 2, 3, '{"a": 4}'), (2, 3, 0, '{"a": 5}')`)
+
+	// Get fingerprints for the table.
+	rows := sqlDB.QueryStr(t, `SHOW EXPERIMENTAL_FINGERPRINTS FROM TABLE d.t`)
+	require.Len(t, rows, 3, "expected only primary, b_idx, c_partial_idx to be fingerprinted")
+	require.Equal(t, rows[0][0], "t_pkey")
+	require.Equal(t, rows[1][0], "b_idx")
+	require.Equal(t, rows[2][0], "c_partial_idx")
+	// NOTE: no d_inverted_idx
+}
+
 // TestShowFingerprintsDuringSchemaChange is a regression test that asserts that
 // fingerprinting does not fail when done in the middle of a schema change using
 // an AOST query. In the middle of a schema change such as `ADD COLUMN ...