Skip to content

Commit c81390f

Browse files
craig[bot]srosenberg
andcommitted
Merge #147122
147122: ci: deadmansnitch for code-cover-gen GH action r=darrylwong,herkolategan a=srosenberg Previously, we had added active monitoring for `code-cover-publish` [1]. However, this time `code-cover-gen` kept failing during build [2]. The latter workflow has `continue-on-error` in order to report the (failure) status to Reviewable.io. Effectively, it was silently failing. This change adds active monitoring for `code-cover-gen`. DMS will alert testeng in case any of the workflow steps fail repeatedly during the 24h interval. [1] #137412 [2] #147052 Epic: none Release note: None Co-authored-by: Stan Rosenberg <[email protected]>
2 parents faeec16 + 7a79ba5 commit c81390f

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

.github/workflows/code-cover-gen.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ jobs:
113113
jq -n --arg err "$msg" '{error: $err}' > artifacts/cover-${PR}-${HEAD_SHA}.json
114114
BASE_SHA=${{ env.BASE_SHA }}
115115
if [ -n "$BASE_SHA" ]; then
116-
jq -n --arg err "$msg" '{error: $err}' > artifacts/cover-${PR}-${BASE_SHA}.json
116+
jq -n --arg err "$msg" '{error: $err}' > artifacts/cover-${PR}-${BASE_SHA}.json
117117
fi
118118
fi
119119
@@ -122,3 +122,8 @@ jobs:
122122
with:
123123
name: cover
124124
path: artifacts/cover-*.json
125+
126+
- name: 'Call DeadManSnitch'
127+
if: env.ERROR == ''
128+
run: |
129+
curl -X GET 'https://nosnch.in/54f81030dc' -d 'message=Code coverage generated'

0 commit comments

Comments
 (0)