Skip to content

Commit c92f38d

Browse files
craig[bot]alyshanjahani-crl
andcommitted
Merge #153286
153286: roachtest: Disable panic_node mutator for mixed-version-endpoints test r=alyshanjahani-crl a=alyshanjahani-crl Previously many runs of the `db-console/mixed-version-endpoints` roachtest would run into a failure mode where accessing the logs endpoint on a node that had previously panic'ed would result in the endpoint returning a 500 (and the test subsequently failing). See #151493. Any run that involves a panic_node mutator in the test plan is bound to run into this issue (since the fix is not backported). This commit should reduce this failure mode significantly by disabling the panic_node mutator. Fixes: #153087 Release note: None Co-authored-by: Alyshan Jahani <[email protected]>
2 parents 95e1d21 + ddf3ae8 commit c92f38d

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

pkg/cmd/roachtest/tests/db_console_endpoints.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,8 @@ func runDBConsoleMixedVersion(ctx context.Context, t test.Test, c cluster.Cluste
112112
c.CRDBNodes(),
113113
// In 24.3 new endpoints were added to /api/v2 server.
114114
mixedversion.MinimumSupportedVersion("v24.3.0"),
115+
// Panics are problematic for the /logs endpoints, see https://github.com/cockroachdb/cockroach/issues/151493.
116+
mixedversion.DisableMutators(mixedversion.PanicNode),
115117
)
116118

117119
mvt.InMixedVersion("test db console endpoints", func(ctx context.Context, l *logger.Logger, rng *rand.Rand, h *mixedversion.Helper) error {

0 commit comments

Comments
 (0)