unify publish-artifacts and publish-provisional-artifacts commands

Previously, we used two similar commands to publish artifacts:
* `pkg/cmd/publish-artifacts`
* `pkg/cmd/publish-provisional-artifacts`

The unified command maintains all existing functionality while providing
a cleaner interface with 'edge' and 'release' subcommands.

Changes:
- Refactored `pkg/cmd/publish-artifacts/main.go` to support subcommands
  using `cobra`.
- Added `edge` and `release` subcommands
- Removed `--provisional` flag; now handled by subcommands
- Removed `--release` flag; it is redundant
- Updated build scripts to use new unified command structure
- Removed `pkg/cmd/publish-provisional-artifacts` directory
- Merged test suites from both commands into unified test file
- Removed support for the old `provisional_yyyymmddhhmm_` naming scheme

Epic: none
Release note: none

Author: rail

build/teamcity/cockroach/post-merge/publish-bleeding-edge-per-platform.sh

@@ -27,5 +27,5 @@ export google_credentials="$gcs_credentials"
 source "build/teamcity-support.sh"  # For log_into_gcloud
 log_into_gcloud
 export GOOGLE_APPLICATION_CREDENTIALS="$PWD/.google-credentials.json"
-$BAZEL_BIN/pkg/cmd/publish-artifacts/publish-artifacts_/publish-artifacts --gcs-bucket="$gcs_bucket" --platform="$platform"
+$BAZEL_BIN/pkg/cmd/publish-artifacts/publish-artifacts_/publish-artifacts edge --gcs-bucket="$gcs_bucket" --platform="$platform"
 EOF

build/teamcity/internal/release/process/build-cockroach-release-per-platform.sh

@@ -51,10 +51,8 @@ tc_end_block "Variable Setup"
 
 
 tc_start_block "Make and publish release artifacts"
-# Using publish-provisional-artifacts here is funky. We're directly publishing
-# the official binaries, not provisional ones. Legacy naming. To clean up...
 BAZEL_SUPPORT_EXTRA_DOCKER_ARGS="-e TC_BUILDTYPE_ID -e TC_BUILD_BRANCH=$version -e gcs_credentials -e gcs_bucket=$gcs_bucket -e platform=$platform -e telemetry_disabled=$telemetry_disabled -e cockroach_archive_prefix=$cockroach_archive_prefix" run_bazel << 'EOF'
-bazel build //pkg/cmd/publish-provisional-artifacts
+bazel build //pkg/cmd/publish-artifacts
 BAZEL_BIN=$(bazel info bazel-bin)
 export google_credentials="$gcs_credentials"
 source "build/teamcity-support.sh"  # For log_into_gcloud
@@ -80,7 +78,7 @@ done
 
 tr -d '\r' < /tmp/THIRD-PARTY-NOTICES.txt.tmp > /tmp/THIRD-PARTY-NOTICES.txt
 
-$BAZEL_BIN/pkg/cmd/publish-provisional-artifacts/publish-provisional-artifacts_/publish-provisional-artifacts -provisional -release --gcs-bucket="$gcs_bucket" --output-directory=artifacts --platform=$platform --third-party-notices-file=/tmp/THIRD-PARTY-NOTICES.txt --telemetry-disabled=$telemetry_disabled --cockroach-archive-prefix=$cockroach_archive_prefix
+$BAZEL_BIN/pkg/cmd/publish-artifacts/publish-artifacts_/publish-artifacts release --gcs-bucket="$gcs_bucket" --output-directory=artifacts --platform=$platform --third-party-notices-file=/tmp/THIRD-PARTY-NOTICES.txt --telemetry-disabled=$telemetry_disabled --cockroach-archive-prefix=$cockroach_archive_prefix
 EOF
 tc_end_block "Make and publish release artifacts"
 

build/teamcity/internal/release/process/make-and-publish-build-artifacts-per-platform.sh

@@ -77,7 +77,7 @@ tc_end_block "Tag the release"
 
 tc_start_block "Compile and publish artifacts"
 BAZEL_SUPPORT_EXTRA_DOCKER_ARGS="-e TC_BUILDTYPE_ID -e TC_BUILD_BRANCH=$build_name -e build_name=$build_name -e gcs_credentials -e gcs_bucket=$gcs_bucket -e platform=$platform -e telemetry_disabled=$telemetry_disabled -e cockroach_archive_prefix=$cockroach_archive_prefix" run_bazel << 'EOF'
-bazel build //pkg/cmd/publish-provisional-artifacts
+bazel build //pkg/cmd/publish-artifacts
 BAZEL_BIN=$(bazel info bazel-bin)
 export google_credentials="$gcs_credentials"
 source "build/teamcity-support.sh"  # For log_into_gcloud
@@ -103,7 +103,7 @@ done
 
 tr -d '\r' < /tmp/THIRD-PARTY-NOTICES.txt.tmp > /tmp/THIRD-PARTY-NOTICES.txt
 
-$BAZEL_BIN/pkg/cmd/publish-provisional-artifacts/publish-provisional-artifacts_/publish-provisional-artifacts -provisional -release --gcs-bucket="$gcs_bucket" --output-directory=artifacts --build-tag-override="$build_name" --platform $platform --third-party-notices-file=/tmp/THIRD-PARTY-NOTICES.txt --telemetry-disabled=$telemetry_disabled --cockroach-archive-prefix=$cockroach_archive_prefix
+$BAZEL_BIN/pkg/cmd/publish-artifacts/publish-artifacts_/publish-artifacts release --gcs-bucket="$gcs_bucket" --output-directory=artifacts --build-tag-override="$build_name" --platform $platform --third-party-notices-file=/tmp/THIRD-PARTY-NOTICES.txt --telemetry-disabled=$telemetry_disabled --cockroach-archive-prefix=$cockroach_archive_prefix
 
 EOF
 tc_end_block "Compile and publish artifacts"

pkg/BUILD.bazel

@@ -145,7 +145,6 @@ ALL_TESTS = [
     "//pkg/cmd/microbench-ci:microbench-ci_test",
     "//pkg/cmd/mirror/go:go_test",
     "//pkg/cmd/publish-artifacts:publish-artifacts_test",
-    "//pkg/cmd/publish-provisional-artifacts:publish-provisional-artifacts_test",
     "//pkg/cmd/reduce/reduce/reducesql:reducesql_test",
     "//pkg/cmd/reduce/reduce:reduce_test",
     "//pkg/cmd/release:release_test",
@@ -1209,9 +1208,6 @@ GO_TARGETS = [
     "//pkg/cmd/publish-artifacts:publish-artifacts",
     "//pkg/cmd/publish-artifacts:publish-artifacts_lib",
     "//pkg/cmd/publish-artifacts:publish-artifacts_test",
-    "//pkg/cmd/publish-provisional-artifacts:publish-provisional-artifacts",
-    "//pkg/cmd/publish-provisional-artifacts:publish-provisional-artifacts_lib",
-    "//pkg/cmd/publish-provisional-artifacts:publish-provisional-artifacts_test",
     "//pkg/cmd/reduce/reduce/reducesql:reducesql",
     "//pkg/cmd/reduce/reduce/reducesql:reducesql_test",
     "//pkg/cmd/reduce/reduce:reduce",

pkg/cmd/publish-artifacts/BUILD.bazel

@@ -8,6 +8,7 @@ go_library(
     deps = [
         "//pkg/release",
         "@com_github_kr_pretty//:pretty",
+        "@com_github_spf13_cobra//:cobra",
     ],
 )