asim: remove some unused fields

Author: tbg

pkg/kv/kvserver/asim/tests/default_settings.go

@@ -34,11 +34,6 @@ const (
 	defaultBytes             = int64(0)
 )
 
-const (
-	defaultStat                 = "replicas"
-	defaultHeight, defaultWidth = 15, 80
-)
-
 const (
 	defaultRequestCPUPerAccess, defaultRaftCPUPerWrite = int64(0), int64(0)
 )
@@ -58,33 +53,26 @@ type staticOptionSettings struct {
 	placementType       gen.PlacementType
 	replicationFactor   int
 	bytes               int64
-	stat                string
-	height              int
-	width               int
 	requestCPUPerAccess int64
 	raftCPUPerWrite     int64
 }
 
 func getDefaultStaticOptionSettings() staticOptionSettings {
 	return staticOptionSettings{
-		nodes:             defaultNodes,
-		storesPerNode:     defaultStoresPerNode,
-		storeByteCapacity: defaultStoreByteCapacity,
-		rwRatio:           defaultRwRatio,
-		rate:              defaultRate,
-		minBlock:          defaultMinBlock,
-		maxBlock:          defaultMaxBlock,
-		minKey:            defaultMinKey,
-		maxKey:            defaultMaxKey,
-		skewedAccess:      defaultSkewedAccess,
-		ranges:            defaultRanges,
-		placementType:     defaultPlacementType,
-		replicationFactor: defaultReplicationFactor,
-		bytes:             defaultBytes,
-		// TODO(tbg): unused, remove.
-		stat:                defaultStat,
-		height:              defaultHeight,
-		width:               defaultWidth,
+		nodes:               defaultNodes,
+		storesPerNode:       defaultStoresPerNode,
+		storeByteCapacity:   defaultStoreByteCapacity,
+		rwRatio:             defaultRwRatio,
+		rate:                defaultRate,
+		minBlock:            defaultMinBlock,
+		maxBlock:            defaultMaxBlock,
+		minKey:              defaultMinKey,
+		maxKey:              defaultMaxKey,
+		skewedAccess:        defaultSkewedAccess,
+		ranges:              defaultRanges,
+		placementType:       defaultPlacementType,
+		replicationFactor:   defaultReplicationFactor,
+		bytes:               defaultBytes,
 		requestCPUPerAccess: defaultRequestCPUPerAccess,
 		raftCPUPerWrite:     defaultRaftCPUPerWrite,
 	}

pkg/kv/kvserver/asim/tests/rand_test.go

@@ -202,9 +202,6 @@ func TestRandomized(t *testing.T) {
 				scanIfExists(t, d, "placement_type", &staticOptionSettings.placementType)
 				scanIfExists(t, d, "replication_factor", &staticOptionSettings.replicationFactor)
 				scanIfExists(t, d, "bytes", &staticOptionSettings.bytes)
-				scanIfExists(t, d, "stat", &staticOptionSettings.stat)
-				scanIfExists(t, d, "height", &staticOptionSettings.height)
-				scanIfExists(t, d, "width", &staticOptionSettings.width)
 				return ""
 			case "rand_ranges":
 				randOptions.ranges = true