Skip to content

Commit ceb0303

Browse files
craig[bot]jeffswensonshailendra-patelsumeerbholarail
committed
145287: workload: add support to csv generation for decimal r=jeffswenson a=jeffswenson PR #144818 modified the tpcc workload so that it generates decimals instead of floats. Usually fixture generation uses a special case in process data generator, but the import roachtests uses a datum -> csv conversation code path that was missing support for the decimal type. Fixes: #145058 Fixes: #145058 Fixes: #145185 Release note: none 145415: drtprod: add YAML files for PUA tests r=vidit-bhat,nameisbhaskar a=shailendra-patel This PR introduces the following changes: 1. Adds YAML configuration files to run Performance Under Adversity (PUA) tests end-to-end. 2. Includes a wait time in the drtprod execution steps. Epic: none Release note: None 145546: go.mod: update tokenbucket to 42689b6 r=RaduBerinde a=sumeerbhola Epic: none Release note: None 145554: workflow: enable auto-merge-backports r=lunevalex a=rail This commit enables auto-merge-backports for the repository. Epic: none Release note: none Co-authored-by: Jeff Swenson <[email protected]> Co-authored-by: Shailendra Patel <[email protected]> Co-authored-by: sumeerbhola <[email protected]> Co-authored-by: Rail Aliiev <[email protected]>
5 parents 616456a + cd15e8e + 1f7e8ed + 3a682b5 + 65649c0 commit ceb0303

File tree

16 files changed

+967
-49
lines changed

16 files changed

+967
-49
lines changed

.github/workflows/auto-merge-backports.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -75,15 +75,15 @@ jobs:
7575
console.log(`Merging PR #${pr.number}, Created at: ${pr.createdAt}, Approved: ${approved}, Labels: ${labels}`);
7676
7777
// Merge the PR
78-
// try {
79-
// console.log(`Merging PR #${pr.number}`);
80-
// await github.rest.pulls.merge({
81-
// owner: context.repo.owner,
82-
// repo: context.repo.repo,
83-
// pull_number: pr.number,
84-
// merge_method: "merge",
85-
// });
86-
// } catch (err) {
87-
// console.warn(`Failed to merge PR #${pr.number}: ${err.message}`);
88-
// }
78+
try {
79+
console.log(`Merging PR #${pr.number}`);
80+
await github.rest.pulls.merge({
81+
owner: context.repo.owner,
82+
repo: context.repo.repo,
83+
pull_number: pr.number,
84+
merge_method: "merge",
85+
});
86+
} catch (err) {
87+
console.warn(`Failed to merge PR #${pr.number}: ${err.message}`);
88+
}
8989
}

DEPS.bzl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1965,10 +1965,10 @@ def go_deps():
19651965
name = "com_github_cockroachdb_tokenbucket",
19661966
build_file_proto_mode = "disable_global",
19671967
importpath = "github.com/cockroachdb/tokenbucket",
1968-
sha256 = "150f3e8e5b515c0886cda0809f09b5d5173d7f2c30eb2f2c6045c2aeb2183aa3",
1969-
strip_prefix = "github.com/cockroachdb/[email protected]20230807174530-cc333fc44b06",
1968+
sha256 = "2802e556b469d0989364cf8244bd4992e34e34a72a8c514df9dd787c694c3efd",
1969+
strip_prefix = "github.com/cockroachdb/[email protected]20250429170803-42689b6311bb",
19701970
urls = [
1971-
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/tokenbucket/com_github_cockroachdb_tokenbucket-v0.0.0-20230807174530-cc333fc44b06.zip",
1971+
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/tokenbucket/com_github_cockroachdb_tokenbucket-v0.0.0-20250429170803-42689b6311bb.zip",
19721972
],
19731973
)
19741974
go_repository(

build/bazelutil/distdir_files.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ DISTDIR_FILES = {
372372
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/strtime/com_github_cockroachdb_strtime-v0.0.0-20250401230151-b9140bbb29b5.zip": "8743d12484dd18c95cfccbd253557ef1d2aa3298299f79eacf62d4a91dd24e6e",
373373
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/swiss/com_github_cockroachdb_swiss-v0.0.0-20250304010804-34a2c6a59016.zip": "b9968f20abf619de68e0276595d8a2ccc6fbfac924446af878805d19c31f6560",
374374
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/tablewriter/com_github_cockroachdb_tablewriter-v0.0.5-0.20200105123400-bd15540e8847.zip": "79daf1c29ec50cdd8dd1ea33f8a814963646a45a2ebe22742d652579340ebde0",
375-
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/tokenbucket/com_github_cockroachdb_tokenbucket-v0.0.0-20230807174530-cc333fc44b06.zip": "150f3e8e5b515c0886cda0809f09b5d5173d7f2c30eb2f2c6045c2aeb2183aa3",
375+
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/tokenbucket/com_github_cockroachdb_tokenbucket-v0.0.0-20250429170803-42689b6311bb.zip": "2802e556b469d0989364cf8244bd4992e34e34a72a8c514df9dd787c694c3efd",
376376
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/tools/com_github_cockroachdb_tools-v0.0.0-20211112185054-642e51449b40.zip": "37a3737dd23768b4997b2f0341d625658f5862cdbf808f7fbf3a7f9fd25913a7",
377377
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/ttycolor/com_github_cockroachdb_ttycolor-v0.0.0-20210902133924-c7d7dcdde4e8.zip": "1260533510c89abd6d8af573a40f0246f6865d5091144dea509b2c48e7c61614",
378378
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/version/com_github_cockroachdb_version-v0.0.0-20250314144055-3860cd14adf2.zip": "4e734ab8c4e4ff81003fedffa30dc5727f9b210c72a188ee3127eeedea09f644",

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ require (
142142
github.com/cockroachdb/redact v1.1.6
143143
github.com/cockroachdb/returncheck v0.0.0-20200612231554-92cdbca611dd
144144
github.com/cockroachdb/stress v0.0.0-20220803192808-1806698b1b7b
145-
github.com/cockroachdb/tokenbucket v0.0.0-20230807174530-cc333fc44b06
145+
github.com/cockroachdb/tokenbucket v0.0.0-20250429170803-42689b6311bb
146146
github.com/cockroachdb/tools v0.0.0-20211112185054-642e51449b40
147147
github.com/cockroachdb/ttycolor v0.0.0-20210902133924-c7d7dcdde4e8
148148
github.com/cockroachdb/version v0.0.0-20250314144055-3860cd14adf2

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -608,8 +608,8 @@ github.com/cockroachdb/swiss v0.0.0-20250304010804-34a2c6a59016 h1:d0dxi6Q8yGtRB
608608
github.com/cockroachdb/swiss v0.0.0-20250304010804-34a2c6a59016/go.mod h1:yBRu/cnL4ks9bgy4vAASdjIW+/xMlFwuHKqtmh3GZQg=
609609
github.com/cockroachdb/tablewriter v0.0.5-0.20200105123400-bd15540e8847 h1:c7yLgqcm/3c9lYtpWeVD9NYqA9cKsKHdpQM62PHtTUM=
610610
github.com/cockroachdb/tablewriter v0.0.5-0.20200105123400-bd15540e8847/go.mod h1:zq6QwlOf5SlnkVbMSr5EoBv3636FWnp+qbPhuoO21uA=
611-
github.com/cockroachdb/tokenbucket v0.0.0-20230807174530-cc333fc44b06 h1:zuQyyAKVxetITBuuhv3BI9cMrmStnpT18zmgmTxunpo=
612-
github.com/cockroachdb/tokenbucket v0.0.0-20230807174530-cc333fc44b06/go.mod h1:7nc4anLGjupUW/PeY5qiNYsdNXj7zopG+eqsS7To5IQ=
611+
github.com/cockroachdb/tokenbucket v0.0.0-20250429170803-42689b6311bb h1:3bCgBvB8PbJVMX1ouCcSIxvsqKPYM7gs72o0zC76n9g=
612+
github.com/cockroachdb/tokenbucket v0.0.0-20250429170803-42689b6311bb/go.mod h1:7nc4anLGjupUW/PeY5qiNYsdNXj7zopG+eqsS7To5IQ=
613613
github.com/cockroachdb/tools v0.0.0-20211112185054-642e51449b40 h1:qVTb3XEv+7VVjPetop8yGbN95HfCeqZx+VMveeSJPZw=
614614
github.com/cockroachdb/tools v0.0.0-20211112185054-642e51449b40/go.mod h1:cllxeV+TYc387/XzQRnDg6YThHoDzFewovWffzAm37Q=
615615
github.com/cockroachdb/ttycolor v0.0.0-20210902133924-c7d7dcdde4e8 h1:Hli+oX84dKq44sLVCcsGKqifm5Lg9J8VoJ2P3h9iPdI=

pkg/cmd/drtprod/cli/commands/yamlprocessor.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import (
1515
"slices"
1616
"strings"
1717
"sync"
18+
"time"
1819

1920
"github.com/cockroachdb/cockroach/pkg/cmd/drtprod/helpers"
2021
"github.com/cockroachdb/cockroach/pkg/roachprod"
@@ -116,6 +117,7 @@ type step struct {
116117
Flags map[string]interface{} `yaml:"flags"` // Flags to pass to the command or script
117118
ContinueOnFailure bool `yaml:"continue_on_failure"` // Whether to continue on failure
118119
OnRollback []step `yaml:"on_rollback"` // Steps to execute if rollback is needed
120+
Wait int `yaml:"wait"` // Wait time in seconds before executing the next step
119121
}
120122

121123
// target defines a target cluster with associated steps to be executed.
@@ -140,6 +142,7 @@ type command struct {
140142
args []string // Command arguments
141143
continueOnFailure bool // Whether to continue on failure
142144
rollbackCmds []*command // Rollback commands to execute in case of failure
145+
wait int // Wait time in seconds before executing the next step
143146
}
144147

145148
// String returns the command as a string for easy printing.
@@ -547,6 +550,10 @@ func executeCommands(ctx context.Context, logPrefix string, cmds []*command) err
547550
fmt.Printf("[%s] Failed <%v>, Error Ignored: %v\n", logPrefix, cmd, err)
548551
} else {
549552
fmt.Printf("[%s] Completed <%v>\n", logPrefix, cmd)
553+
if cmd.wait > 0 {
554+
fmt.Printf("[%s] Waiting for %d seconds\n", logPrefix, cmd.wait)
555+
time.Sleep(time.Duration(cmd.wait) * time.Second)
556+
}
550557
}
551558

552559
// Add rollback commands if specified
@@ -604,6 +611,7 @@ func generateStepCmd(clusterName string, s step) (*command, error) {
604611
return nil, err
605612
}
606613
}
614+
cmd.wait = s.Wait
607615
return cmd, err
608616
}
609617

0 commit comments

Comments
 (0)