Skip to content

Commit d0bc242

Browse files
committed
kvserver: incorporate blob file compression metrics
Release note: None Epic: none
1 parent 9bee340 commit d0bc242

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

pkg/kv/kvserver/metrics.go

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4242,15 +4242,16 @@ func (sm *StoreMetrics) updateEngineMetrics(m storage.Metrics) {
42424242
sm.SSTableRemoteBytes.Update(int64(size))
42434243
sm.SSTableRemoteCount.Update(int64(count))
42444244

4245-
// TODO(radu): aggregate blob file compression metrics when those are added.
4246-
sm.CompressionSnappyBytes.Update(int64(m.Table.Compression.Snappy.CompressedBytes))
4247-
sm.CompressionSnappyCR.Update(m.Table.Compression.Snappy.CompressionRatio())
4248-
sm.CompressionMinLZBytes.Update(int64(m.Table.Compression.MinLZ.CompressedBytes))
4249-
sm.CompressionMinLZCR.Update(m.Table.Compression.MinLZ.CompressionRatio())
4250-
sm.CompressionZstdBytes.Update(int64(m.Table.Compression.Zstd.CompressedBytes))
4251-
sm.CompressionZstdCR.Update(m.Table.Compression.Zstd.CompressionRatio())
4252-
sm.CompressionNoneBytes.Update(int64(m.Table.Compression.NoCompressionBytes))
4253-
sm.CompressionUnknownBytes.Update(int64(m.Table.Compression.CompressedBytesWithoutStats))
4245+
c := m.Table.Compression
4246+
c.MergeWith(&m.BlobFiles.Compression)
4247+
sm.CompressionSnappyBytes.Update(int64(c.Snappy.CompressedBytes))
4248+
sm.CompressionSnappyCR.Update(c.Snappy.CompressionRatio())
4249+
sm.CompressionMinLZBytes.Update(int64(c.MinLZ.CompressedBytes))
4250+
sm.CompressionMinLZCR.Update(c.MinLZ.CompressionRatio())
4251+
sm.CompressionZstdBytes.Update(int64(c.Zstd.CompressedBytes))
4252+
sm.CompressionZstdCR.Update(c.Zstd.CompressionRatio())
4253+
sm.CompressionNoneBytes.Update(int64(c.NoCompressionBytes))
4254+
sm.CompressionUnknownBytes.Update(int64(c.CompressedBytesWithoutStats))
42544255

42554256
overall := pebble.CompressionStatsForSetting{
42564257
CompressedBytes: m.Table.Compression.NoCompressionBytes,

0 commit comments

Comments
 (0)