asim: rename generateAllPlots

Author: tbg

pkg/kv/kvserver/asim/tests/datadriven_simulation_test.go

@@ -567,7 +567,7 @@ func TestDataDriven(t *testing.T) {
 						// parameter to the `eval` command.
 						testName := name + "_" + mv
 						for sample, h := range run.hs {
-							generateAllPlots(t, &buf, h, testName, sample+1, plotDir, hasher, rewrite,
+							printStatsAndGenerateJSON(t, &buf, h, testName, sample+1, plotDir, hasher, rewrite,
 								settingsGen.Settings.TickInterval, metricsMap)
 							generateTopology(t, h,
 								filepath.Join(plotDir, fmt.Sprintf("%s_%d_topology.txt", testName, sample+1)),

pkg/kv/kvserver/asim/tests/plotting_test.go

@@ -21,14 +21,13 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-// generateAllPlots creates plots for all available metrics from simulation history.
+// printStatsAndGenerateJSON creates plots for all available metrics from simulation history.
 // All plot files are hashed directly to the provided hasher.
 // If rewrite is false, plots are generated but not saved to disk.
 // Returns a slice of filenames for all generated plots.
 //
 // TODO(tbg): introduce a SimulationEnv and make this a method on it.
-// TODO(tbg): rename to generateArtifacts.
-func generateAllPlots(
+func printStatsAndGenerateJSON(
 	t *testing.T,
 	buf *strings.Builder,
 	h history.History,