sql: remove duplicated hints cache local variables

yuzefovich · yuzefovich · commit da6d6d9d2de9 · 2025-11-06T19:56:28.000-08:00
Release note: None
diff --git a/pkg/sql/conn_executor_exec.go b/pkg/sql/conn_executor_exec.go
@@ -901,10 +901,6 @@ func (ex *connExecutor) execStmtInOpenState(
 				typeHints[i] = resolved
 			}
 		}
-		var statementHintsCache *hints.StatementHintsCache
-		if ex.executorType != executorTypeInternal {
-			statementHintsCache = ex.server.cfg.StatementHintsCache
-		}
 		prepStmt := makeStatement(
 			ctx,
 			statements.Statement[tree.Statement]{
@@ -1883,10 +1879,6 @@ func (ex *connExecutor) execStmtInOpenStateWithPausablePortal(
 				typeHints[i] = resolved
 			}
 		}
-		var statementHintsCache *hints.StatementHintsCache
-		if ex.executorType != executorTypeInternal {
-			statementHintsCache = ex.server.cfg.StatementHintsCache
-		}
 		prepStmt := makeStatement(
 			ctx,
 			statements.Statement[tree.Statement]{

Original file line number	Diff line number	Diff line change
`@@ -901,10 +901,6 @@ func (ex *connExecutor) execStmtInOpenState(`
`901`	`901`	`typeHints[i] = resolved`
`902`	`902`	`}`
`903`	`903`	`}`
`904`		`- var statementHintsCache *hints.StatementHintsCache`
`905`		`- if ex.executorType != executorTypeInternal {`
`906`		`- statementHintsCache = ex.server.cfg.StatementHintsCache`
`907`		`- }`
`908`	`904`	`prepStmt := makeStatement(`
`909`	`905`	`ctx,`
`910`	`906`	`statements.Statement[tree.Statement]{`
`@@ -1883,10 +1879,6 @@ func (ex *connExecutor) execStmtInOpenStateWithPausablePortal(`
`1883`	`1879`	`typeHints[i] = resolved`
`1884`	`1880`	`}`
`1885`	`1881`	`}`
`1886`		`- var statementHintsCache *hints.StatementHintsCache`
`1887`		`- if ex.executorType != executorTypeInternal {`
`1888`		`- statementHintsCache = ex.server.cfg.StatementHintsCache`
`1889`		`- }`
`1890`	`1882`	`prepStmt := makeStatement(`
`1891`	`1883`	`ctx,`
`1892`	`1884`	`statements.Statement[tree.Statement]{`