Merge pull request #151007 from fqazi/blathers/backport-release-25.3-150979

release-25.3: workload/schemachanger: fix trigger function generation

Author: rafiss

pkg/workload/schemachange/operation_generator.go

@@ -5398,8 +5398,9 @@ func (og *operationGenerator) createTrigger(ctx context.Context, tx pgx.Tx) (*op
 	if err != nil {
 		return nil, err
 	}
-
-	triggerFunction := fmt.Sprintf(`CREATE FUNCTION %s() RETURNS TRIGGER AS $FUNC_BODY$ BEGIN %s;RETURN NULL;END; $FUNC_BODY$ LANGUAGE PLpgSQL`, triggerFunctionName, selectStmt.sql)
+	// Our trigger function will always return the original value to avoid
+	// breaking inserts.
+	triggerFunction := fmt.Sprintf(`CREATE FUNCTION %s() RETURNS TRIGGER AS $FUNC_BODY$ BEGIN %s;RETURN NEW;END; $FUNC_BODY$ LANGUAGE PLpgSQL`, triggerFunctionName, selectStmt.sql)
 
 	og.LogMessage(fmt.Sprintf("Created trigger function %s", triggerFunction))