Merge #143180

craig[bot] · sambhav-jain-16 · craig[bot] · commit e2b64154831d · 2025-03-25T14:16:31.000Z
143180: workload: remove `workload` label from openmetrics r=herkolategan a=sambhav-jain-16

workload label was added to the openmetrics exporter earlier. This is not needed and only increases the file size, hence removing it.

Epic: none

Release note: None

Co-authored-by: Sambhav Jain &lt;sambhav.jain@cockroachlabs.com&gt;
diff --git a/pkg/workload/cli/run.go b/pkg/workload/cli/run.go
@@ -687,8 +687,6 @@ func maybeInitAndCreateExporter(gen workload.Generator) (exporter.Exporter, *os.
 			}
 			labels[strings.TrimSpace(parts[0])] = strings.TrimSpace(parts[1])
 		}
-		// Append workload generator name as a tag
-		labels["workload"] = gen.Meta().Name
 		openMetricsExporter := exporter.OpenMetricsExporter{}
 		openMetricsExporter.SetLabels(&labels)
 		metricsExporter = &openMetricsExporter

Original file line number	Diff line number	Diff line change
`@@ -687,8 +687,6 @@ func maybeInitAndCreateExporter(gen workload.Generator) (exporter.Exporter, *os.`
`687`	`687`	`}`
`688`	`688`	`labels[strings.TrimSpace(parts[0])] = strings.TrimSpace(parts[1])`
`689`	`689`	`}`
`690`		`- // Append workload generator name as a tag`
`691`		`- labels["workload"] = gen.Meta().Name`
`692`	`690`	`openMetricsExporter := exporter.OpenMetricsExporter{}`
`693`	`691`	`openMetricsExporter.SetLabels(&labels)`
`694`	`692`	`metricsExporter = &openMetricsExporter`