Skip to content

Commit e407a4e

Browse files
committed
compose/compare: disable DO blocks
We just saw a stack overflow due to an infinite recursion when evaluating top-level DO block which has an inner DO block and some loops. I couldn't reproduce the failure, but this test doesn't make it easy (e.g. it doesn't log CREATE TABLE stmts), so we'll just disable DO blocks specifically for this test, hoping that other tests will reproduce the issue. Release note: None
1 parent aa0ff2b commit e407a4e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pkg/compose/compare/compare/compare_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ func TestCompare(t *testing.T) {
8080
configs := map[string]testConfig{
8181
"mutators": {
8282
setup: sqlsmith.Setups[sqlsmith.RandTableSetupName],
83-
opts: []sqlsmith.SmitherOption{sqlsmith.CompareMode()},
83+
opts: []sqlsmith.SmitherOption{sqlsmith.CompareMode(), sqlsmith.DisableDoBlocks()},
8484
ignoreSQLErrors: true,
8585
conns: []testConn{
8686
{

0 commit comments

Comments
 (0)