Skip to content

Commit e59a556

Browse files
committed
asim: do not reset log tags
The asim tests run in parallel now, and this was erasing a log marker that allows us to separate the log lines by test case.
1 parent 4093ac1 commit e59a556

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

pkg/kv/kvserver/asim/mmaintegration/mma_store_rebalancer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ func NewMMAStoreRebalancer(
8888
// Tick is called periodically to check for and apply rebalancing operations
8989
// using mmaprototype.Allocator.
9090
func (msr *MMAStoreRebalancer) Tick(ctx context.Context, tick time.Time, s state.State) {
91-
ctx = msr.ResetAndAnnotateCtx(ctx)
91+
ctx = msr.AnnotateCtx(ctx)
9292
ctx = logtags.AddTag(ctx, "t", tick.Sub(msr.settings.StartTime))
9393

9494
if !msr.currentlyRebalancing &&

pkg/kv/kvserver/asim/queue/lease_queue.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ func (lq *leaseQueue) MaybeAdd(ctx context.Context, replica state.Replica, s sta
113113
// order on ties.
114114
func (lq *leaseQueue) Tick(ctx context.Context, tick time.Time, s state.State) {
115115
lq.AddLogTag("tick", tick)
116-
ctx = lq.ResetAndAnnotateCtx(ctx)
116+
ctx = lq.AnnotateCtx(ctx)
117117
// TODO(wenyihu6): it is unclear why next tick is forwarded to last tick
118118
// here (see #149904 for more details).
119119
if lq.lastTick.After(lq.next) {

pkg/kv/kvserver/asim/queue/replicate_queue.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ func (rq *replicateQueue) MaybeAdd(ctx context.Context, replica state.Replica, s
112112
// supports processing ConsiderRebalance actions on replicas.
113113
func (rq *replicateQueue) Tick(ctx context.Context, tick time.Time, s state.State) {
114114
rq.AddLogTag("tick", tick)
115-
ctx = rq.ResetAndAnnotateCtx(ctx)
115+
ctx = rq.AnnotateCtx(ctx)
116116
// TODO(wenyihu6): it is unclear why next tick is forwarded to last tick
117117
// here (see #149904 for more details).
118118
if rq.lastTick.After(rq.next) {

pkg/kv/kvserver/asim/storerebalancer/store_rebalancer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ func (src *storeRebalancerControl) checkPendingTicket() (done bool, _ error) {
156156

157157
func (src *storeRebalancerControl) Tick(ctx context.Context, tick time.Time, state state.State) {
158158
src.sr.AddLogTag("tick", tick.Sub(src.settings.StartTime))
159-
ctx = src.sr.ResetAndAnnotateCtx(ctx)
159+
ctx = src.sr.AnnotateCtx(ctx)
160160
switch src.rebalancerState.phase {
161161
case rebalancerSleeping:
162162
src.phaseSleep(ctx, tick, state)

0 commit comments

Comments
 (0)