Skip to content

Commit e5c5ac0

Browse files
committed
asim: fix io_overload
This test started failing after we fixed the skew distribution, since it relied on the replica count on store 5 starting and ending at 0. After fixing the skew distribution, the replica count on store 5 no longer began at 0, even though the total leases/replica count on s5 didn’t change throughout the test which means we weren't adding more leases/replicas to the s5. This change updates the test to force the replica count on store 5 to start at 0 again.
1 parent 0129614 commit e5c5ac0

File tree

1 file changed

+24
-30
lines changed

1 file changed

+24
-30
lines changed
Lines changed: 24 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,21 @@
1+
# This test verifies that the allocator correctly handles IO overload by
2+
# avoiding placement of replicas on stores that exceed the IO threshold. It
3+
# sets up a 5-node cluster where store 5 has an IO threshold of 1, causing it
4+
# to be considered overloaded and excluded from replica placement decisions.
5+
# It is expected that s5 will start with 0 replicas and stay at 0 replicas for
6+
# the duration of the test.
17
skip_under_ci
28
----
39

410
gen_cluster nodes=5
511
----
612

7-
gen_ranges ranges=500 placement_type=skewed
13+
gen_ranges ranges=500 placement_type=replica_placement
14+
{s1,s2,s3}:1
15+
{s1,s2,s4}:1
816
----
17+
{s1:*,s2,s3}:1
18+
{s1:*,s2,s4}:1
919

1020
set_capacity store=5 io_threshold=1
1121
----
@@ -14,37 +24,21 @@ set_capacity store=5 io_threshold=1
1424
assertion type=stat stat=replicas stores=(5) exact_bound=0 ticks=5
1525
----
1626

17-
eval duration=10m seed=42 metrics=(replicas,leases) cfgs=(sma-count,mma-only)
27+
eval duration=5m seed=42 metrics=(replicas,leases) cfgs=(sma-count,mma-only)
1828
----
19-
leases#1: first: [s1=259, s2=129, s3=64, s4=32, s5=16] (stddev=88.43, mean=100.00, sum=500)
20-
leases#1: last: [s1=180, s2=102, s3=106, s4=106, s5=6] (stddev=55.34, mean=100.00, sum=500)
21-
leases#1: thrash_pct: [s1=23%, s2=23%, s3=20%, s4=27%, s5=0%] (sum=93%)
22-
replicas#1: first: [s1=500, s2=456, s3=262, s4=165, s5=117] (stddev=153.29, mean=300.00, sum=1500)
23-
replicas#1: last: [s1=347, s2=343, s3=348, s4=345, s5=117] (stddev=91.52, mean=300.00, sum=1500)
24-
replicas#1: thrash_pct: [s1=47%, s2=44%, s3=46%, s4=48%, s5=0%] (sum=184%)
25-
artifacts[sma-count]: 937f126429994d65
26-
failed assertion sample 1
27-
stat=replicas value=(=0.00) ticks=5
28-
store=5 stat=117.00
29-
store=5 stat=117.00
30-
store=5 stat=117.00
31-
store=5 stat=117.00
32-
store=5 stat=117.00
33-
store=5 stat=117.00
29+
leases#1: first: [s1=500, s2=0, s3=0, s4=0, s5=0] (stddev=200.00, mean=100.00, sum=500)
30+
leases#1: last: [s1=329, s2=25, s3=75, s4=71, s5=0] (stddev=117.93, mean=100.00, sum=500)
31+
leases#1: thrash_pct: [s1=0%, s2=0%, s3=0%, s4=0%, s5=0%] (sum=0%)
32+
replicas#1: first: [s1=500, s2=500, s3=250, s4=250, s5=0] (stddev=187.08, mean=300.00, sum=1500)
33+
replicas#1: last: [s1=375, s2=375, s3=375, s4=375, s5=0] (stddev=150.00, mean=300.00, sum=1500)
34+
replicas#1: thrash_pct: [s1=0%, s2=0%, s3=3%, s4=0%, s5=0%] (sum=3%)
35+
artifacts[sma-count]: 742eaa2acee55191
3436
==========================
35-
leases#1: first: [s1=259, s2=129, s3=64, s4=32, s5=16] (stddev=88.43, mean=100.00, sum=500)
36-
leases#1: last: [s1=259, s2=145, s3=64, s4=32, s5=0] (stddev=92.98, mean=100.00, sum=500)
37+
leases#1: first: [s1=500, s2=0, s3=0, s4=0, s5=0] (stddev=200.00, mean=100.00, sum=500)
38+
leases#1: last: [s1=500, s2=0, s3=0, s4=0, s5=0] (stddev=200.00, mean=100.00, sum=500)
3739
leases#1: thrash_pct: [s1=0%, s2=0%, s3=0%, s4=0%, s5=0%] (sum=0%)
38-
replicas#1: first: [s1=500, s2=456, s3=262, s4=165, s5=117] (stddev=153.29, mean=300.00, sum=1500)
39-
replicas#1: last: [s1=500, s2=456, s3=262, s4=165, s5=117] (stddev=153.29, mean=300.00, sum=1500)
40+
replicas#1: first: [s1=500, s2=500, s3=250, s4=250, s5=0] (stddev=187.08, mean=300.00, sum=1500)
41+
replicas#1: last: [s1=500, s2=500, s3=250, s4=250, s5=0] (stddev=187.08, mean=300.00, sum=1500)
4042
replicas#1: thrash_pct: [s1=0%, s2=0%, s3=0%, s4=0%, s5=0%] (sum=0%)
41-
artifacts[mma-only]: 88981cebae8fb4b9
42-
failed assertion sample 1
43-
stat=replicas value=(=0.00) ticks=5
44-
store=5 stat=117.00
45-
store=5 stat=117.00
46-
store=5 stat=117.00
47-
store=5 stat=117.00
48-
store=5 stat=117.00
49-
store=5 stat=117.00
43+
artifacts[mma-only]: d6dfa8b63a078f25
5044
==========================

0 commit comments

Comments
 (0)