asim: fix bug with missing ticket in controller

Previously, tickets were incorrectly deleted immediately after checking for
their existence, even if they weren't completed yet. This caused tickets to be
missing on subsequent checks. This commit fixes the issue by keeping the tickets
around.

Epic: none
Release note: none

Author: wenyihu6

pkg/kv/kvserver/asim/op/controller.go

@@ -115,9 +115,6 @@ func (c *controller) Tick(ctx context.Context, tick time.Time, state state.State
 // If the ticket exists, it returns the operation and true, else false.
 func (c *controller) Check(ticket DispatchedTicket) (op ControlledOperation, ok bool) {
 	op, ok = c.tickets[ticket]
-	if ok {
-		delete(c.tickets, ticket)
-	}
 	return op, ok
 }
 

pkg/kv/kvserver/asim/storerebalancer/store_rebalancer_test.go

@@ -136,8 +136,8 @@ func TestStoreRebalancer(t *testing.T) {
 				rebalancerSleeping,
 				rangeRebalancing,
 				rangeRebalancing,
-				rebalancerSleeping,
-				rebalancerSleeping,
+				rangeRebalancing,
+				rangeRebalancing,
 				rebalancerSleeping,
 				rebalancerSleeping,
 			},
@@ -146,7 +146,7 @@ func TestStoreRebalancer(t *testing.T) {
 				{1: 3200, 2: 3000, 3: 3000, 4: 0, 5: 0, 6: 0},
 				{1: 2400, 2: 3000, 3: 3000, 4: 0, 5: 0, 6: 800},
 				{1: 2400, 2: 3000, 3: 3000, 4: 0, 5: 0, 6: 800},
-				{1: 1600, 2: 3000, 3: 3000, 4: 800, 5: 0, 6: 800},
+				{1: 2400, 2: 3000, 3: 3000, 4: 0, 5: 0, 6: 800},
 				{1: 1600, 2: 3000, 3: 3000, 4: 800, 5: 0, 6: 800},
 				{1: 1600, 2: 3000, 3: 3000, 4: 800, 5: 0, 6: 800},
 			},