Skip to content

Commit e7943b7

Browse files
craig[bot]mw5h
andcommitted
Merge #153627
153627: explain_test: deflake TestContentionTimeOnWrites r=mw5h a=mw5h This test that introduces contention on writes for testing purposes wasn't retrying retriable errors. In this case, it appears that the wait we inserted to ensure the we can see the contention in the second worker has pushed us over the limit into "too old" territory. Because of the non-trivial amount of semaphore logic, we just tear the whole thing down and retry it instead of localizing the retry logic in the worker getting these errors. Fixes: #153394 Release note: None Co-authored-by: Matt White <[email protected]>
2 parents 1c43745 + 706ab83 commit e7943b7

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

pkg/sql/opt/exec/explain/output_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,8 @@ func TestContentionTimeOnWrites(t *testing.T) {
231231
defer leaktest.AfterTest(t)()
232232
defer log.Scope(t).Close(t)
233233

234+
skip.UnderDuress(t, "see issue #153394")
235+
234236
ctx := context.Background()
235237
s, conn, _ := serverutils.StartServer(t, base.TestServerArgs{})
236238
defer s.Stopper().Stop(ctx)

0 commit comments

Comments
 (0)