Merge #149663 #149981

149663: roachtest: skip many perturbation tests r=arulajmani a=stevendanna

These tests are useful for a few reasons:

1. They are very sensitive to latency outliers (something we care about!).

2. They test our ability to post-mortem debug non-fatal issues such as latency increases.

3. They help ensure that the impact of the given perturbations don't get worse.

Unfortunately, they also result in a large number of time-consuming failures. Our strategy to bring them under control is to skip those with high failure rates and then work, as time allows, to re-enable them one by one.

Epic: none
Release note: None

149981: ui: fix text overflow on job details page r=kyle-a-wong a=kyle-a-wong

If the error message for a failed job contained long unbreakable strings, it prevents the error message component from shrinking, causing it to be hidden under other components.

Now, the error message component will be able to break anywhere so that it can be legible on smaller viewports.

Resolves: CC-33142
Epic: CC-32806
Release note: None

Co-authored-by: Steven Danna <[email protected]>
Co-authored-by: Kyle Wong <[email protected]>

Author: 3 people

pkg/cmd/roachtest/tests/perturbation/framework.go

@@ -272,27 +272,31 @@ func setup(p perturbation, acceptableChange float64) variations {
 	return v
 }
 
-func register(r registry.Registry, p perturbation) {
-	// Metamorphic perturbation tests are currently disabled. See
+func register(r registry.Registry, p perturbation, skipReason string) {
+	// All metamorphic perturbation tests are currently disabled. See
 	// https://github.com/cockroachdb/cockroach/issues/142148.
-	// addMetamorphic(r, p)
-	addFull(r, p)
+	addMetamorphic(r, p, "#142148")
+	addFull(r, p, skipReason)
 	addDev(r, p)
 }
 
 func RegisterTests(r registry.Registry) {
-	// NB: If these tests fail because they are flaky, increase the numbers
-	// until they pass. Additionally add the seed (from the log) that caused
-	// them to fail as a comment in the test.
-	register(r, restart{})
-	register(r, partition{})
-	register(r, addNode{})
-	register(r, decommission{})
-	register(r, backfill{})
-	register(r, &slowDisk{})
-	register(r, elasticWorkload{})
-	register(r, intents{})
-	register(r, backup{})
+	const notSkipped = ""
+	const skippedByBankruptcy = "#149662"
+
+	register(r, restart{}, notSkipped)
+	register(r, backup{}, notSkipped)
+
+	// TODO(ssd): We skipped the majority of these tests so that we can focus on
+	// one at a time. These are vaguely ordered by their previous pass rate
+	// (highest first).
+	register(r, intents{}, skippedByBankruptcy)
+	register(r, decommission{}, skippedByBankruptcy)
+	register(r, elasticWorkload{}, skippedByBankruptcy)
+	register(r, partition{}, skippedByBankruptcy)
+	register(r, backfill{}, notSkipped)
+	register(r, &slowDisk{}, skippedByBankruptcy)
+	register(r, addNode{}, skippedByBankruptcy)
 }
 
 func (v variations) makeClusterSpec() spec.ClusterSpec {
@@ -415,13 +419,14 @@ var perturbationDefaultProcessFunction = func(test string, histograms *roachtest
 }
 
 //lint:ignore U1000 unused
-func addMetamorphic(r registry.Registry, p perturbation) {
+func addMetamorphic(r registry.Registry, p perturbation, skipReason string) {
 	rng, seed := randutil.NewPseudoRand()
 	v := p.setupMetamorphic(rng)
 	v.seed = seed
 	v = v.finishSetup()
 	r.Add(registry.TestSpec{
 		Name:                   fmt.Sprintf("perturbation/metamorphic/%s", v.perturbationName()),
+		Skip:                   skipReason,
 		CompatibleClouds:       v.cloud,
 		Suites:                 registry.Suites(registry.Perturbation),
 		Owner:                  registry.OwnerKV,
@@ -433,11 +438,12 @@ func addMetamorphic(r registry.Registry, p perturbation) {
 	})
 }
 
-func addFull(r registry.Registry, p perturbation) {
+func addFull(r registry.Registry, p perturbation, skipReason string) {
 	v := p.setup()
 	v = v.finishSetup()
 	r.Add(registry.TestSpec{
 		Name:                   fmt.Sprintf("perturbation/full/%s", v.perturbationName()),
+		Skip:                   skipReason,
 		CompatibleClouds:       v.cloud,
 		Suites:                 registry.Suites(registry.Nightly),
 		Owner:                  registry.OwnerKV,

pkg/ui/workspaces/cluster-ui/src/jobs/jobs.module.scss

@@ -210,6 +210,7 @@
 .inline-message {
   margin-top: $spacing-smaller;
   width: 100%;
+  overflow-wrap: anywhere;
 }
 
 .page--header {