Skip to content

Commit e9eadd2

Browse files
committed
kvserver: fix storage.write-amplification
Fix the storage.write-amplification timeseries metric to use the same calculation performed by pebble. Fix #148959. Epic: none Release note: none
1 parent 164a4ba commit e9eadd2

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

pkg/kv/kvserver/metrics.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4144,14 +4144,13 @@ func (sm *StoreMetrics) updateEngineMetrics(m storage.Metrics) {
41444144
sm.categoryIterMetrics.update(m.CategoryStats)
41454145
sm.categoryDiskWriteMetrics.update(m.DiskWriteStats)
41464146

4147-
totalWriteAmp := float64(0)
41484147
for level, stats := range m.Levels {
41494148
sm.RdbBytesIngested[level].Update(int64(stats.TableBytesIngested))
41504149
sm.RdbLevelSize[level].Update(stats.TablesSize)
41514150
sm.RdbLevelScore[level].Update(stats.Score)
4152-
totalWriteAmp += stats.WriteAmp()
41534151
}
4154-
sm.StorageWriteAmplification.Update(totalWriteAmp)
4152+
tot := m.Total()
4153+
sm.StorageWriteAmplification.Update(tot.WriteAmp())
41554154
sm.StoragePointDeletionsBytes.Update(int64(m.Table.Garbage.PointDeletionsBytesEstimate))
41564155
sm.StorageRangeDeletionsBytes.Update(int64(m.Table.Garbage.RangeDeletionsBytesEstimate))
41574156
statsComplete := int64(0)

0 commit comments

Comments
 (0)