gen: don't consider OnRecording as a changed setting

Author: tbg

pkg/kv/kvserver/asim/gen/printer.go

@@ -33,7 +33,8 @@ func compareSettingsToDefault(settings config.SimulationSettings) string {
 		// Skip cluster setting ST and seed. The simulation seed is derived from
 		// rand.New(rand.NewSource(42)).Int63() by default, while the default
 		// simulation setting itself uses 42.
-		if field.Name == "ST" || field.Name == "Seed" {
+		// We also skip the OnRecording callback.
+		if field.Name == "ST" || field.Name == "Seed" || field.Name == "OnRecording" {
 			continue
 		}
 

pkg/kv/kvserver/asim/tests/testdata/generated/example_rebalancing/example_rebalancing_setup.txt

@@ -13,5 +13,4 @@ Event
 Workload Set Up
 	[1,10000): 95%r large-block [128-256B/op, 7000ops/s]
 Changed Settings
-	StateExchangeDelay: 20s (default: 500ms)
-	OnRecording: 0x10487ef50 (default: <nil>)
+	StateExchangeDelay: 20s (default: 500ms)

pkg/kv/kvserver/asim/tests/testdata/non_rand/mma_skewed_cpu_skewed_write.txt

@@ -73,5 +73,4 @@ Workload Set Up
 	[10001,20000): write-only large-block [0.00cpu-us/write(raft), 1000B/op, 20000ops/s]
 Changed Settings
 	SplitQueueEnabled: false (default: true)
-	OnRecording: 0x10487ef50 (default: <nil>)
 ==========================