changefeedccl: fix TestAlterChangefeedAddTargetsDuringSchemaChangeError

andyyang890 · andyyang890 · commit f3fabf4377c5 · 2025-09-23T09:13:34.000-04:00
This patch deflakes a unit test that started failing because the change
to checkpoint aggregators regularly meant that setting a low span-level
checkpoint interval wasn't enough to make sure a checkpoint happened
quickly enough during the test.

Release note: None
diff --git a/pkg/ccl/changefeedccl/alter_changefeed_test.go b/pkg/ccl/changefeedccl/alter_changefeed_test.go
@@ -1349,7 +1349,8 @@ func TestAlterChangefeedAddTargetsDuringSchemaChangeError(t *testing.T) {
 			return nil
 		}
 
-		testFeed := feed(t, f, `CREATE CHANGEFEED FOR foo WITH resolved = '1s', no_initial_scan`)
+		testFeed := feed(t, f, `CREATE CHANGEFEED FOR foo
+WITH resolved = '1s', no_initial_scan, min_checkpoint_frequency='1ns'`)
 		jobFeed := testFeed.(cdctest.EnterpriseTestFeed)
 		jobRegistry := s.Server.JobRegistry().(*jobs.Registry)
 

Original file line number	Diff line number	Diff line change
`@@ -1349,7 +1349,8 @@ func TestAlterChangefeedAddTargetsDuringSchemaChangeError(t *testing.T) {`
`1349`	`1349`	`return nil`
`1350`	`1350`	`}`
`1351`	`1351`
`1352`		- testFeed := feed(t, f, `CREATE CHANGEFEED FOR foo WITH resolved = '1s', no_initial_scan`)
	`1352`	+ testFeed := feed(t, f, `CREATE CHANGEFEED FOR foo
	`1353`	+WITH resolved = '1s', no_initial_scan, min_checkpoint_frequency='1ns'`)
`1353`	`1354`	`jobFeed := testFeed.(cdctest.EnterpriseTestFeed)`
`1354`	`1355`	`jobRegistry := s.Server.JobRegistry().(*jobs.Registry)`
`1355`	`1356`