Skip to content

Commit f411e6d

Browse files
committed
asim: set settingsGen.Settings.OnRecording if tr is enabled
Previously, asim was setting settingsGen.Settings.OnRecording on if tr is disabled which was unintentional. This commit fixes it to set OnRecording when tr is enabled instead.
1 parent ea2242b commit f411e6d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pkg/kv/kvserver/asim/tests/datadriven_simulation_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -577,7 +577,7 @@ func TestDataDriven(t *testing.T) {
577577
seedGen := rand.New(rand.NewSource(seed))
578578
for sample := 0; sample < samples; sample++ {
579579
tr := makeTraceHelper(rewrite, plotDir, testName, sample+1, duration)
580-
if !tr.enabled {
580+
if tr.enabled {
581581
// Only populate OnRecording if we're going to save the results.
582582
// That way, we avoid creating trace spans during normal test runs.
583583
settingsGen.Settings.OnRecording = func(storeID int64, atDuration time.Duration, rec tracingpb.Recording) {

0 commit comments

Comments
 (0)