Skip to content

Commit f69afc5

Browse files
committed
sql: grow stack for DistSQL goroutines
This commit makes it so that the main goroutine of Outbox and the vectorized hash router goroutine now start out with the larger stack. Release note: None
1 parent a627560 commit f69afc5

File tree

4 files changed

+6
-0
lines changed

4 files changed

+6
-0
lines changed

pkg/sql/colflow/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ go_library(
4646
"//pkg/util",
4747
"//pkg/util/admission",
4848
"//pkg/util/buildutil",
49+
"//pkg/util/growstack",
4950
"//pkg/util/grunning",
5051
"//pkg/util/log",
5152
"//pkg/util/metric",

pkg/sql/colflow/vectorized_flow.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ import (
4343
"github.com/cockroachdb/cockroach/pkg/util"
4444
"github.com/cockroachdb/cockroach/pkg/util/admission"
4545
"github.com/cockroachdb/cockroach/pkg/util/buildutil"
46+
"github.com/cockroachdb/cockroach/pkg/util/growstack"
4647
"github.com/cockroachdb/cockroach/pkg/util/log"
4748
"github.com/cockroachdb/cockroach/pkg/util/metric"
4849
"github.com/cockroachdb/cockroach/pkg/util/mon"
@@ -718,6 +719,7 @@ func (s *vectorizedFlowCreator) accumulateAsyncComponent(run runFn) {
718719
flowinfra.StartableFn(func(ctx context.Context, wg *sync.WaitGroup, flowCtxCancel context.CancelFunc) {
719720
wg.Add(1)
720721
go func() {
722+
growstack.Grow()
721723
defer wg.Done()
722724
run(ctx, flowCtxCancel)
723725
}()

pkg/sql/flowinfra/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ go_library(
4242
"//pkg/util/buildutil",
4343
"//pkg/util/cancelchecker",
4444
"//pkg/util/ctxlog",
45+
"//pkg/util/growstack",
4546
"//pkg/util/hlc",
4647
"//pkg/util/log",
4748
"//pkg/util/mon",

pkg/sql/flowinfra/outbox.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import (
1717
"github.com/cockroachdb/cockroach/pkg/sql/execinfrapb"
1818
"github.com/cockroachdb/cockroach/pkg/sql/rowenc"
1919
"github.com/cockroachdb/cockroach/pkg/sql/types"
20+
"github.com/cockroachdb/cockroach/pkg/util/growstack"
2021
"github.com/cockroachdb/cockroach/pkg/util/log"
2122
"github.com/cockroachdb/cockroach/pkg/util/syncutil"
2223
"github.com/cockroachdb/cockroach/pkg/util/timeutil"
@@ -412,6 +413,7 @@ func (m *Outbox) Start(ctx context.Context, wg *sync.WaitGroup, flowCtxCancel co
412413
m.flowCtxCancel = flowCtxCancel
413414
wg.Add(1)
414415
go func() {
416+
growstack.Grow()
415417
defer wg.Done()
416418
m.setErr(m.mainLoop(ctx, wg))
417419
}()

0 commit comments

Comments
 (0)