Merge #158048

158048: mmaprototype: release rangeAnalyzedConstraints properly r=wenyihu6 a=wenyihu6

Epic: CRDB-55052 
Release note: none

---
**mmaprototype: release rangeAnalyzedConstraints properly**

Previously, we weren’t calling releaseRangeAnalyzedConstraints on
rangeAnalyzedConstraints, which could lead to resource leak. This
commit calls releaseRangeAnalyzedConstraints when they are unused.



Co-authored-by: wenyihu6 <[email protected]>

Author: craig[bot]

pkg/kv/kvserver/allocator/mmaprototype/cluster_state.go

@@ -1313,6 +1313,16 @@ func (rs *rangeState) removePendingChangeTracking(changeID changeID) {
 	}
 }
 
+// clearAnalyzedConstraints clears the analyzed constraints for the range state.
+// This should be used when rs is deleted or rs.constraints needs to be reset.
+func (rs *rangeState) clearAnalyzedConstraints() {
+	if rs.constraints == nil {
+		return
+	}
+	releaseRangeAnalyzedConstraints(rs.constraints)
+	rs.constraints = nil
+}
+
 // clusterState is the state of the cluster known to the allocator, including
 // adjustments based on pending changes. It does not include additional
 // indexing needed for constraint matching, or for tracking ranges that may
@@ -1662,7 +1672,7 @@ func (cs *clusterState) processStoreLeaseholderMsgInternal(
 		// assuming the leaseholder wouldn't have sent the message if there was no
 		// change, or we noticed a divergence in membership above and fell through
 		// here.
-		rs.constraints = nil
+		rs.clearAnalyzedConstraints()
 	}
 	// Remove ranges for which this is the localRangeOwner, but for which it is
 	// no longer the leaseholder.
@@ -1703,6 +1713,7 @@ func (cs *clusterState) processStoreLeaseholderMsgInternal(
 			}
 			delete(cs.stores[replica.StoreID].adjusted.replicas, r)
 		}
+		rs.clearAnalyzedConstraints()
 		delete(cs.ranges, r)
 	}
 	localss := cs.stores[msg.StoreID]
@@ -1961,7 +1972,7 @@ func (cs *clusterState) undoPendingChange(cid changeID) {
 		panic(errors.AssertionFailedf("pending change is marked as no-rollback"))
 	}
 	// Wipe the analyzed constraints, as the range has changed.
-	rs.constraints = nil
+	rs.clearAnalyzedConstraints()
 	rs.lastFailedChange = cs.ts.Now()
 	// Undo the change delta as well as the replica change and remove the pending
 	// change from all tracking (range, store, cluster).