Skip to content

Commit f8fe590

Browse files
committed
history: update a comment
I think I first wrote it before improving the thrashing measure to use the trend-discounting total variation. There was also a sentence in there that I did not understand any more, so I removed it.
1 parent 859983e commit f8fe590

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

pkg/kv/kvserver/asim/history/thrashing.go

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,12 @@ type thrashing struct {
2828
uptv, dntv float64 // upwards and downwards total variations (both nonnegative)
2929
// normTV is a normalization factor for the total variation. By default, it is
3030
// initialized to the range of the input values, i.e. max - min (or 1 if max
31-
// == min). `tv/normTV` then measures how many times thrashing has "swept out"
32-
// the effective range of values the time series has taken on. This measure
33-
// can be misleading if the time series has early outliers that are not
34-
// accounted for in the total variation, but for the applications at hand it
35-
// generally makes sense. `tv/normTV` can grow arbitrarily large if the time
36-
// series oscillates frequently (and enough datapoints are present). To get
37-
// a sense of a "thrashing rate", `tv/(normTV*T)` or `tv/(normTV*runs) could
38-
// be of interest.
31+
// == min). `tdtv/normTV` then measures how many times thrashing has "swept out"
32+
// the effective range of values the time series has taken on.
33+
// `tdtv/normTV` can grow arbitrarily large if the time series oscillates
34+
// frequently (and enough datapoints are present). To get a sense of a
35+
// "thrashing rate", `tdtv/(normTV*T)` or `tdtv/(normTV*runs) could be of
36+
// interest.
3937
normTV float64
4038
}
4139

0 commit comments

Comments
 (0)