Skip to content

Commit f95fe85

Browse files
committed
workload: increase burst for changefeed limiter
The inbound work from the rangefeed is not evenly distributed over a 1s interval. For changefeeds, we mostly care about whether the configured rate is or is not sufficient for the given write rate over rather long time intervals. Using a large burst helps make we get the desired rate over those longer time horizons. Epic: CRDB-55203 Release note: none
1 parent 91b1736 commit f95fe85

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pkg/workload/cli/run.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,9 @@ func runRun(gen workload.Generator, urls []string, dbName string) error {
441441
}
442442
var changefeedLimiter *rate.Limiter
443443
if *changefeedMaxRate > 0 {
444-
changefeedLimiter = rate.NewLimiter(rate.Limit(*changefeedMaxRate), 1)
444+
ratePerSecond := *changefeedMaxRate
445+
burst := max(int(ratePerSecond), 1)
446+
changefeedLimiter = rate.NewLimiter(rate.Limit(ratePerSecond), burst)
445447
}
446448

447449
maybeLogRandomSeed(ctx, gen)

0 commit comments

Comments
 (0)