Skip to content

Commit f9a6276

Browse files
committed
changefeedccl: increase timeout for test making many tables
This test timed out in CI while trying to create 50000 tables. After an hour, it created about 40,000. Adding another hour should be enough time to finish creation and run the 20 minute workload. We also saw a test failure where this pts management metric came in slightly above the threshold of 25ms, so we raise that to 30ms. Epic: none Fixes: #152654 Fixes: #152962 Release note: None
1 parent 4b3c782 commit f9a6276

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

pkg/cmd/roachtest/tests/cdc.go

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1872,7 +1872,7 @@ func runCDCMultiTablePTSBenchmark(
18721872
ct.verifyMetrics(ctx, ct.verifyMetricsUnderThreshold([]string{
18731873
"changefeed_stage_pts_manage_latency",
18741874
"changefeed_stage_pts_create_latency",
1875-
}, float64(25*time.Millisecond)))
1875+
}, float64(30*time.Millisecond)))
18761876

18771877
t.Status("multi-table PTS benchmark finished")
18781878
}
@@ -2912,12 +2912,13 @@ func registerCDC(r registry.Registry) {
29122912

29132913
for _, perTablePTS := range []bool{false, true} {
29142914
for _, config := range []struct {
2915-
numTables int
2916-
numRanges int
2915+
numTables int
2916+
numRanges int
2917+
timeoutHours int
29172918
}{
2918-
{numTables: 500, numRanges: 10},
2919-
{numTables: 5000, numRanges: 10},
2920-
{numTables: 50000, numRanges: 1}, // Splitting tables into ranges slows down test setup at this scale
2919+
{numTables: 500, numRanges: 10, timeoutHours: 1},
2920+
{numTables: 5000, numRanges: 10, timeoutHours: 1},
2921+
{numTables: 50000, numRanges: 1, timeoutHours: 2}, // Splitting tables into ranges slows down test setup at this scale
29212922
} {
29222923
r.Add(registry.TestSpec{
29232924
Name: fmt.Sprintf("cdc/multi-table-pts-benchmark/per-table-pts=%t/num-tables=%d/num-ranges=%d", perTablePTS, config.numTables, config.numRanges),
@@ -2926,7 +2927,7 @@ func registerCDC(r registry.Registry) {
29262927
Cluster: r.MakeClusterSpec(4, spec.CPU(16), spec.WorkloadNode()),
29272928
CompatibleClouds: registry.AllClouds,
29282929
Suites: registry.Suites(registry.Nightly),
2929-
Timeout: 1 * time.Hour,
2930+
Timeout: time.Duration(config.timeoutHours) * time.Hour,
29302931
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
29312932
params := multiTablePTSBenchmarkParams{
29322933
numTables: config.numTables,

0 commit comments

Comments
 (0)