kvserver: add destroy replica to TestReplicaLifecycleDataDriven

This adds a very basic version of ReplicaDestroy to the test suite.

Epic: none

Release note: None

Author: arulajmani

pkg/kv/kvserver/replica_lifecycle_datadriven_test.go

@@ -81,6 +81,12 @@ import (
 //
 //	Executes the split trigger for the specified range on n1.
 //
+// destroy-replica range-id=<int>
+// ----
+//
+//	Destroys the replica on n1 for the specified range. The replica's state
+//	must have already been created via create-replica.
+//
 // print-range-state [sort-keys=<bool>]
 // ----
 //
@@ -149,7 +155,7 @@ func TestReplicaLifecycleDataDriven(t *testing.T) {
 				if rs.replica != nil {
 					return errors.New("initialized replica already exists on n1/s1").Error()
 				}
-				repl := rs.getReplicaDescriptor(t, roachpb.NodeID(1))
+				repl := rs.mustGetReplicaDescriptor(t, roachpb.NodeID(1))
 
 				batch := tc.storage.NewBatch()
 				defer batch.Close()
@@ -210,7 +216,8 @@ func TestReplicaLifecycleDataDriven(t *testing.T) {
 				replicaNodeID := dd.ScanArg[roachpb.NodeID](t, d, "replica")
 				leaseType := dd.ScanArgOr(t, d, "lease-type", "leader-lease")
 				rs := tc.mustGetRangeState(t, rangeID)
-				targetReplica := rs.getReplicaDescriptor(t, replicaNodeID)
+				targetReplica := rs.mustGetReplicaDescriptor(t, replicaNodeID)
+
 				// NB: The details of the lease are not important to the test;
 				// only the type is.
 				var lease roachpb.Lease
@@ -283,6 +290,33 @@ func TestReplicaLifecycleDataDriven(t *testing.T) {
 				// we manually split things out here.
 				return strings.ReplaceAll(output, "\n\n", "\n")
 
+			case "destroy-replica":
+				rangeID := dd.ScanArg[roachpb.RangeID](t, d, "range-id")
+				rs := tc.mustGetRangeState(t, rangeID)
+				rs.mustGetReplicaDescriptor(t, roachpb.NodeID(1)) // ensure replica exists
+
+				batch := tc.storage.NewBatch()
+				defer batch.Close()
+
+				err := kvstorage.DestroyReplica(
+					ctx,
+					kvstorage.TODOReadWriter(batch),
+					kvstorage.DestroyReplicaInfo{
+						FullReplicaID: rs.replica.FullReplicaID,
+						Keys:          roachpb.RSpan{Key: rs.desc.StartKey, EndKey: rs.desc.EndKey},
+					},
+					rs.desc.NextReplicaID,
+				)
+				require.NoError(t, err)
+				output, err := print.DecodeWriteBatch(batch.Repr())
+				require.NoError(t, err)
+				err = batch.Commit(true)
+				require.NoError(t, err)
+
+				// Clear the replica from the range state.
+				rs.replica = nil
+				return output
+
 			case "print-range-state":
 				var sb strings.Builder
 				if len(tc.ranges) == 0 {
@@ -440,7 +474,7 @@ func (tc *testCtx) updatePostSplitRangeState(
 	tc.ranges[split.RightDesc.RangeID] = rhsRangeState
 }
 
-func (rs *rangeState) getReplicaDescriptor(
+func (rs *rangeState) mustGetReplicaDescriptor(
 	t *testing.T, nodeID roachpb.NodeID,
 ) *roachpb.ReplicaDescriptor {
 	for i, repl := range rs.desc.InternalReplicas {

pkg/kv/kvserver/testdata/replica_lifecycle/destroy_replica.txt

@@ -0,0 +1,27 @@
+create-descriptor start=a end=z replicas=(1,2,3)
+----
+created descriptor: r1:{a-z} [(n1,s1):1, (n2,s2):2, (n3,s3):3, next=4, gen=0]
+
+create-replica range-id=1 initialized
+----
+created replica: (n1,s1):1
+Put: 0,0 /Local/RangeID/1/r/RangeLease (0x01698972726c6c2d00): <empty>
+Put: 0,0 /Local/RangeID/1/r/RangeGCThreshold (0x016989726c67632d00): 0,0
+Put: 0,0 /Local/RangeID/1/r/RangeGCHint (0x016989727267636800): latest_range_delete_timestamp:<> gc_timestamp:<> gc_timestamp_next:<> 
+Put: 0,0 /Local/RangeID/1/r/RangeVersion (0x016989727276657200): 10.8-upgrading-step-007
+Put: 0,0 /Local/RangeID/1/r/RangeAppliedState (0x016989727261736b00): raft_applied_index:10 lease_applied_index:10 range_stats:<sys_bytes:142 sys_count:4 > raft_closed_timestamp:<> raft_applied_index_term:5 
+Put: 0,0 /Local/RangeID/1/u/RaftReplicaID (0x016989757266747200): replica_id:1 
+Put: 0,0 /Local/RangeID/1/u/RaftHardState (0x016989757266746800): term:5 vote:0 commit:10 lead:0 lead_epoch:0 
+Put: 0,0 /Local/RangeID/1/u/RaftTruncatedState (0x016989757266747400): index:10 term:5 
+
+destroy-replica range-id=1
+----
+Delete (Sized at 28): 0,0 /Local/RangeID/1/r/RangeGCThreshold (0x016989726c67632d00): 
+Delete (Sized at 43): 0,0 /Local/RangeID/1/r/RangeAppliedState (0x016989727261736b00): 
+Delete (Sized at 34): 0,0 /Local/RangeID/1/r/RangeGCHint (0x016989727267636800): 
+Delete (Sized at 44): 0,0 /Local/RangeID/1/r/RangeLease (0x01698972726c6c2d00): 
+Delete (Sized at 36): 0,0 /Local/RangeID/1/r/RangeVersion (0x016989727276657200): 
+Put: 0,0 /Local/RangeID/1/u/RangeTombstone (0x016989757266746200): next_replica_id:4 
+Delete (Sized at 38): 0,0 /Local/RangeID/1/u/RaftHardState (0x016989757266746800): 
+Delete: 0,0 /Local/RangeID/1/u/RaftReplicaID (0x016989757266747200): 
+Delete (Sized at 32): 0,0 /Local/RangeID/1/u/RaftTruncatedState (0x016989757266747400):