Skip to content

Commit fcb4bbf

Browse files
committed
roachprod: fix target inverse secure flag
A small regression was introduced in #149369 which passes the incorrect secure flag to `createLabels` for `node_exporter`, `ebpf_exporter`, and `workload`, causing the metrics not to be scraped. Fixes: #149512 Epic: None Release note: None
1 parent ac3b2b7 commit fcb4bbf

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

pkg/roachprod/roachprod.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -851,11 +851,11 @@ func updatePrometheusTargets(
851851
nodeIPPorts[nodeID] = []*promhelperclient.NodeInfo{
852852
{
853853
Target: fmt.Sprintf("%s:%d", nodeIP, vm.NodeExporterPort),
854-
CustomLabels: createLabels(nodeID, v, "node_exporter", false),
854+
CustomLabels: createLabels(nodeID, v, "node_exporter", true),
855855
},
856856
{
857857
Target: fmt.Sprintf("%s:%d", nodeIP, vm.EbpfExporterPort),
858-
CustomLabels: createLabels(nodeID, v, "ebpf_exporter", false),
858+
CustomLabels: createLabels(nodeID, v, "ebpf_exporter", true),
859859
},
860860
}
861861
}
@@ -877,7 +877,7 @@ func updatePrometheusTargets(
877877
nodeIPPorts[nodeID],
878878
&promhelperclient.NodeInfo{
879879
Target: fmt.Sprintf("%s:%d", nodeIP, port),
880-
CustomLabels: createLabels(nodeID, v, "workload", false),
880+
CustomLabels: createLabels(nodeID, v, "workload", true),
881881
},
882882
)
883883
}

0 commit comments

Comments
 (0)