Skip to content

Commit fe6b420

Browse files
committed
kvserver,db-console: enable leader lease quiescence by default
This commit enables leader lease quiescence by default and adds the new quiesced replicas metric to the Replication DB console dashboard. Part of: #133885 Release note (ui change): The Replica Quiescence graph on the Replication dashboard in the DB Console Metrics now displays the number of replicas quiesced with leader leases.
1 parent ce3c356 commit fe6b420

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

pkg/kv/kvserver/replica_store_liveness_sleep.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import (
99
"github.com/cockroachdb/cockroach/pkg/kv/kvserver/kvserverpb"
1010
"github.com/cockroachdb/cockroach/pkg/settings"
1111
"github.com/cockroachdb/cockroach/pkg/util/envutil"
12-
"github.com/cockroachdb/cockroach/pkg/util/metamorphic"
1312
)
1413

1514
// RaftStoreLivenessQuiescenceEnabled controls whether store liveness quiescence
@@ -18,9 +17,7 @@ var RaftStoreLivenessQuiescenceEnabled = settings.RegisterBoolSetting(
1817
settings.SystemOnly,
1918
"kv.raft.store_liveness.quiescence.enabled",
2019
"controls whether store liveness quiescence is enabled",
21-
metamorphic.ConstantWithTestChoice("kv.raft.store_liveness.quiescence.enabled",
22-
false, /* defaultValue */
23-
true /* otherValues */),
20+
true,
2421
)
2522

2623
// goToSleepAfterTicks is the number of Raft ticks after which a follower can

pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/replication.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,14 @@ export default function (props: GraphDashboardProps) {
207207
>
208208
<Axis label="replicas">
209209
<Metric name="cr.store.replicas" title="Replicas" />
210-
<Metric name="cr.store.replicas.quiescent" title="Quiescent" />
210+
<Metric
211+
name="cr.store.replicas.quiescent"
212+
title="Epoch Lease Quiescent"
213+
/>
214+
<Metric
215+
name="cr.store.replicas.asleep"
216+
title="Leader Lease Quiescent"
217+
/>
211218
</Axis>
212219
</LineGraph>,
213220

0 commit comments

Comments
 (0)