Skip to content

Commit ff553d0

Browse files
committed
changefeedccl: add more verbose logging around schema changes
This patch adds more verbose logging to the change aggregator around receiving and emitting resolved spans to help debug recurring changefeed schema change test flakes. Release note: None
1 parent 8898577 commit ff553d0

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

pkg/ccl/changefeedccl/changefeed_processors.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -867,6 +867,10 @@ func (ca *changeAggregator) flushBufferedEvents() error {
867867
// changeAggregator node to the changeFrontier node to allow the changeFrontier
868868
// to persist the overall changefeed's progress
869869
func (ca *changeAggregator) noteResolvedSpan(resolved jobspb.ResolvedSpan) (returnErr error) {
870+
if log.V(2) {
871+
log.Infof(ca.Ctx(), "resolved span from kv feed: %#v", resolved)
872+
}
873+
870874
if resolved.Timestamp.IsEmpty() {
871875
// @0.0 resolved timestamps could come in from rangefeed checkpoint.
872876
// When rangefeed starts running, it emits @0.0 resolved timestamp.
@@ -950,6 +954,9 @@ func (ca *changeAggregator) emitResolved(batch jobspb.ResolvedSpans) error {
950954
RecentKvCount: ca.recentKVCount,
951955
},
952956
}
957+
if log.V(2) {
958+
log.Infof(ca.Ctx(), "progress update to be sent to change frontier: %#v", progressUpdate)
959+
}
953960
updateBytes, err := protoutil.Marshal(&progressUpdate)
954961
if err != nil {
955962
return err

0 commit comments

Comments
 (0)