sql/schemachanger: fix incorrect filter for secondary index recreation during a pk swap #154751
Description
The secondary index rule for swapping out indexes during a primary recreation have a bug, which can prevent the deprule from being enforced consistently. This issues lies at:
The filter incorrectly operates on the old secondary index instead of the new one and has the incorrect parameter order. So it very likely was never enforced.
Jira issue: CRDB-55105