Merged
Conversation
jbowens
approved these changes
Nov 21, 2025
Contributor
jbowens
left a comment
jbowens
left a comment
There was a problem hiding this comment.
@jbowens reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RaduBerinde)
crstrings/utils.go line 148 at r1 (raw file):
var separator string for _, l := range strings.Split(input, "\n") {
nit: can use SplitSeq
(will need to rebase over main to pick up #27 for the Go version)
RaduBerinde
force-pushed
the
unwrap-text
branch
from
3c7ffa8 to
f4e3378
Compare
Add a helper that makes it easy to define long strings.
RaduBerinde
force-pushed
the
unwrap-text
branch
from
f4e3378 to
f31b1e6
Compare
RaduBerinde
commented
Nov 21, 2025
Member
Author
RaduBerinde
left a comment
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @jbowens)
crstrings/utils.go line 148 at r1 (raw file):
Previously, jbowens (Jackson Owens) wrote…
nit: can use
SplitSeq(will need to rebase over main to pick up #27 for the Go version)
Done, TFTR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a helper that makes it easy to define long strings.
This change is