Skip to content

confirm support for CockroachDB 25.4 #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timgraham merged 1 commit into from
Dec 3, 2025
Merged

confirm support for CockroachDB 25.4 #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ jobs:
use_psycopg2: psycopg2
- crdb-version: v25.3.1
use_server_side_binding: server_side_binding
- crdb-version: v25.4.0
- crdb-version: v25.4.0
use_psycopg2: psycopg2
- crdb-version: v25.4.0
use_server_side_binding: server_side_binding
# Uncomment to enable testing of CockroachDB nightly.
#- crdb-version: LATEST
#- crdb-version: LATEST
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## 5.2.1 - Unreleased

- Confirmed support for CockroachDB 25.2.x and 25.3.x (no code changes
- Confirmed support for CockroachDB 25.2.x, 25.3.x, and 25.4.x (no code changes
required).
- Fixed the ``Now`` database function to use the statement time
(``STATEMENT_TIMESTAMP``) rather than the transaction time
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ By default, CockroachDB sends the version of django-cockroachdb that you're
using back to Cockroach Labs. To disable this, set
`DISABLE_COCKROACHDB_TELEMETRY = True` in your Django settings.

## Known issues and limitations in CockroachDB 25.3.x and earlier
## Known issues and limitations in CockroachDB 25.4.x and earlier

- CockroachDB [can't disable constraint checking](https://github.com/cockroachdb/cockroach/issues/19444),
which means certain things in Django like forward references in fixtures
Expand Down
12 changes: 12 additions & 0 deletions django_cockroachdb/features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ def is_cockroachdb_25_1(self):
def is_cockroachdb_25_2(self):
return self.connection.cockroachdb_version >= (25, 2)

@cached_property
def is_cockroachdb_25_4(self):
return self.connection.cockroachdb_version >= (25, 4)

@cached_property
def django_test_expected_failures(self):
expected_failures = super().django_test_expected_failures
Expand Down Expand Up @@ -356,4 +360,12 @@ def django_test_skips(self):
'schema.tests.SchemaTests.test_alter_field_type_and_db_collation',
},
})
if self.is_cockroachdb_25_4:
skips.update({
# Error truncating hundreds of tables:
# https://github.com/cockroachdb/cockroach/issues/156682
Copy link
Contributor

@rafiss rafiss Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for finding this issue. it unfortunately will only be fixed in v26.1.

'Test fails when run with all apps.': {
'migration_test_data_persistence.tests.MigrationDataPersistenceClassSetup',
},
})
return skips