Skip to content

Commit 9497644

Browse files
committed
In essential-metrics.md, added check for advanced_excluded_metrics.
1 parent a00f09d commit 9497644

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/current/_includes/v25.4/essential-metrics.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{% assign version = page.version.version | replace: ".", "" %}
2+
{% assign advanced_excluded_metrics = "sys.cpu.host.combined.percent-normalized|sys.host.disk.iopsinprogress|sql.mem.root.current|storage.write-stalls" | split: "|" %}
23
{% comment %}DEBUG: {{ version }}{% endcomment %}
34

45
{% comment %} STEP 1. Assign variables specific to deployment {% endcomment %}
@@ -122,7 +123,9 @@ The **Usage** column explains why each metric is important to visualize and how
122123
{% for metric in essential_metrics %}
123124
{% comment %} STEP 4d. Exclude SQL metrics that will be placed in special categories {% endcomment %}
124125
{% unless category_name == SQL %}
125-
{% unless metric.name contains "backup" or metric.name contains "BACKUP" or metric.name contains "create_stats" %}
126+
{% comment %} Hide metrics that should not appear for advanced deployment {% endcomment %}
127+
{% unless include.deployment == 'advanced' and advanced_excluded_metrics contains metric.name %}
128+
{% unless metric.name contains "backup" or metric.name contains "BACKUP" or metric.name contains "create_stats" %}
126129

127130
{% comment %} Transforms to match datadog_id {% endcomment %}
128131
{% assign input_metric = metric.name %}
@@ -162,7 +165,8 @@ The **Usage** column explains why each metric is important to visualize and how
162165
<td>{{ metric.how_to_use }}</td>
163166
</tr>
164167

165-
{% endunless %}{% comment %}unless metric.name contains "backup" or metric.name contains "BACKUP" or metric.name contains "create_stats"{% endcomment %}
168+
{% endunless %}{% comment %}unless metric.name contains "backup" or metric.name contains "BACKUP" or metric.name contains "create_stats"{% endcomment %}
169+
{% endunless %}{% comment %}unless metric is excluded for advanced deployment{% endcomment %}
166170
{% endunless %}{% comment %}unless category_name == SQL{% endcomment %}
167171
{% endfor %}{% comment %}for metric in essential_metrics{% endcomment %}
168172
{% endfor %}{% comment %}for layer in layer_names_array{% endcomment %}
@@ -296,4 +300,4 @@ The **Usage** column explains why each metric is important to visualize and how
296300
- [Visualize metrics in Grafana]({% link {{ page.version.version }}/monitor-cockroachdb-with-prometheus.md %}#step-5-visualize-metrics-in-grafana)
297301
- [Custom Chart Debug Page]({% link {{ page.version.version }}/ui-custom-chart-debug-page.md %})
298302
- [Cluster API]({% link {{ page.version.version }}/cluster-api.md %})
299-
- [Essential Alerts]({% link {{ page.version.version }}/essential-alerts-self-hosted.md %})
303+
- [Essential Alerts]({% link {{ page.version.version }}/essential-alerts-self-hosted.md %})

0 commit comments

Comments
 (0)