protobuf: recompile using gogoproto 1.2 from CRDB master

Generated Protobufs have been a mix of gogoproto 1.2 and 1.3 types,
since different packages have been compiled with different Protobuf
compilers. This was in part because `Makefile.update-protos` only
covered `errorspb/*.proto`, with other Protobufs compiled ad hoc. This
was problematic since CockroachDB currently uses gogoproto 1.2 and thus
could not make use of the 1.3-generated types.

This patch changes `Makefile.update-protos` to compile all Protobufs in
the repo, and recompiles all Protobufs using the current Protobuf
compiler used in CockroachDB.

Note in particular that this downgrades generated Protobufs for
`extgrpc`, `exthttp`, and `grpc` from gogoproto 1.3 to 1.2, which might
be considered a breaking change.

This also addresses [CVE-2021-3121](https://nvd.nist.gov/vuln/detail/CVE-2021-3121).

Author: erikgrinaker

Makefile.update-protos

@@ -23,21 +23,33 @@
 #
 # 2. run `make -f Makefile.update-protos` with this PATH active.
 
-PROTOS := $(wildcard errorspb/*.proto)
+export SHELL := env PWD=$(CURDIR) bash
+
+PROTOS := $(wildcard \
+	errbase/internal/*.proto \
+	errorspb/*.proto \
+	extgrpc/*.proto \
+	exthttp/*.proto \
+	grpc/*.proto \
+	markers/internal/*.proto \
+)
 GO_SOURCES = $(PROTOS:.proto=.pb.go)
 
 SED = sed
 SED_INPLACE := $(shell $(SED) --version 2>&1 | grep -q GNU && echo -i || echo "-i ''")
 
 all: $(PROTOS)
-	protoc \
-	   -I$$GOPATH/src/ \
-	   -I$$GOPATH/src/github.com \
-	   -I$$GOPATH/src/github.com/cockroachdb/errors \
-	   -I$$GOPATH/src/github.com/gogo/protobuf \
-	   -I$$GOPATH/src/github.com/gogo/protobuf/protobuf \
-	  --gogoroach_out=Mgoogle/protobuf/any.proto=github.com/gogo/protobuf/types,plugins=grpc,import_prefix=:. \
-	  $(PROTOS)
+	set -e; for dir in $(sort $(dir $(PROTOS))); do \
+		protoc \
+			-I. \
+			-I$$GOPATH/src/ \
+			-I$$GOPATH/src/github.com \
+			-I$$GOPATH/src/github.com/cockroachdb/errors \
+			-I$$GOPATH/src/github.com/gogo/protobuf \
+			-I$$GOPATH/src/github.com/gogo/protobuf/protobuf \
+			--gogoroach_out=Mgoogle/protobuf/any.proto=github.com/gogo/protobuf/types,plugins=grpc,import_prefix=:. \
+			$$dir/*.proto; \
+	done
 	$(SED) $(SED_INPLACE) -E \
 		-e '/import _ /d' \
 		-e 's!import (fmt|math) "github.com/(fmt|math)"! !g' \

errbase/internal/unknown.pb.go

@@ -14,8 +14,6 @@
 
 package extgrpc
 
-//go:generate protoc ext_grpc.proto --gogofaster_out=.
-
 import (
 	"context"
 	"fmt"